-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure-docs] Deploying with ACR. #26187
base: dpeng817/aks_agent
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
065ba2a
to
54b3b79
Compare
2c906ff
to
6aa56b7
Compare
6aa56b7
to
a1892b7
Compare
|
||
## Next steps | ||
|
||
Now that you have an agent running on your AKS cluster, you can start deploying Dagster code to it. You can follow the guide [here](/concepts/deployment/azure/acr-user-code) to deploy user code to your AKS cluster backed by Azure Container Registry (ACR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link path appears to be incorrect. The document is located at /dagster-plus/deployment/azure/acr-user-code
, but the link references /concepts/deployment/azure/acr-user-code
. Please update the path to match the actual document location.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
We'll copy the contents of the `dagster-cloud-hybrid-quickstart` repository into our `dagster-plus-code` repository, and commit the changes. | ||
|
||
```bash | ||
cp -r dagster-cloud-hybrid-quickstart/* dagster-plus-code/ --exclude=".git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cp
command with --exclude
flag won't work on most systems. For reliable exclusion of the .git
directory, use rsync
instead:
rsync -av --exclude='.git' dagster-cloud-hybrid-quickstart/ dagster-plus-code/
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Then, we'll make images from our ACR available to our AKS cluster. | ||
|
||
```bash | ||
az aks update -n <your-namespace> -g <your_resource_group> --attach-acr dagstercodelocations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter <your-namespace>
should be <your-cluster-name>
since this command updates an AKS cluster. The namespace is a Kubernetes concept, while this Azure CLI command operates at the cluster level.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Summary & Motivation
How I Tested These Changes
Changelog