-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure-docs] Deploying with ACR. #26187
Conversation
065ba2a
to
54b3b79
Compare
2c906ff
to
6aa56b7
Compare
6aa56b7
to
a1892b7
Compare
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (12/03/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
54b3b79
to
2c5e484
Compare
a1892b7
to
450218f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my point about other CI/CD needs to be addressed.
otherwise, I am wondering how much we want to duplicate and maintain the documentation that is already there: https://docs.dagster.io/dagster-plus/getting-started#step-4-configure-cicd-for-your-project vs merging them or cross referencing through them.
However, there is merit to having this in a step by step guide, as the user doesn't have to navigate so much as in the existing documentation. But it might get tedious to keep up-to-date in the future. I guess that's a question for @neverett to chime in.
Yea I think that eventually we want to figure out how to merge everything together in a more coherent way. But I think the way that most users will interact with the docs site is either we'll send them a particular page, or they'll search something up. And I want to make sure there's a linear pathway when they search up |
I strongly agree with this. Our current docs have you constantly chasing links. I believe Nikki calls it "stand alone pages". Each page doesn't need to contain the whole world, but it should be useful on its own. |
2c5e484
to
08e6eac
Compare
ce3da57
to
515e1da
Compare
08e6eac
to
295cae8
Compare
515e1da
to
16b3a59
Compare
295cae8
to
8ebe64c
Compare
16b3a59
to
cda2458
Compare
8ebe64c
to
fe8672d
Compare
cda2458
to
4202f03
Compare
fe8672d
to
0005bee
Compare
4202f03
to
b0a8fb6
Compare
0005bee
to
10f2f22
Compare
b0a8fb6
to
f9c11a1
Compare
10f2f22
to
db04b19
Compare
f9c11a1
to
73d2549
Compare
## Summary & Motivation Add docs on using the azure blob storage compute log manager in AKS. ## How I Tested These Changes I followed these instructions myself to get it set up.
db04b19
to
7f0d555
Compare
f01c3f9
to
477cf53
Compare
477cf53
into
dpeng817/fix_compute_log_manager
--identity-name agent-identity \ | ||
--resource-group <resource-group> \ | ||
--issuer $(az aks show -g <resource-group> -n <aks-cluster-name> --query "oidcIssuerProfile.issuerUrl" -otsv) \ | ||
--subject system:serviceaccount:dagster-agent:dagster-agent-service-account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --subject
parameter references dagster-agent-service-account
but this service account was created earlier with the name dagster-agent-sa
. To maintain consistency, the command should be updated to:
--subject system:serviceaccount:dagster-agent:dagster-agent-sa
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Summary & Motivation
A guide on deploying dagster code locations using azure container registry.
Similarly to the previous PR, mostly focuses on the necessary azure incantations. Want someone to vet that nothing here is bad practice.
How I tested this
I deployed code locations myself using this method.