Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): canary-ci again #1057

Closed
wants to merge 44 commits into from
Closed

fix(workflow): canary-ci again #1057

wants to merge 44 commits into from

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 10, 2024

following #1051 and #1054, which are reverted in #1062.

  • make CI with canary work
  • consider supporting any react version

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 24, 2024 0:05am

Copy link

codesandbox-ci bot commented Dec 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Dec 13, 2024
dai-shi added a commit that referenced this pull request Dec 13, 2024
revert #1051 and #1054 for now.
let's continue experiments in #1057.
@@ -4,7 +4,12 @@ on:
push:
branches: [main]
pull_request:
types: [opened, synchronize]
types: [opened]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revert this when it works and is ready for merge.

@dai-shi
Copy link
Owner Author

dai-shi commented Jan 7, 2025

closing in favor of #1118.

@dai-shi dai-shi closed this Jan 7, 2025
@dai-shi dai-shi deleted the canary-ci-2-fix-2 branch January 7, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant