Skip to content

feat: Apache.ActiveMq, AWS.SNS, Azure.ServiceBus, Firebird #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 71 commits into from
May 26, 2025
Merged

Conversation

samtrion
Copy link
Member

@samtrion samtrion commented May 5, 2025

Closed: #54
Closed: #41
Closed: #57
Closed: #704

@samtrion samtrion added the type:feature Indicates a new feature or enhancement to be added. label May 5, 2025
@samtrion samtrion self-assigned this May 5, 2025
@samtrion samtrion requested a review from a team as a code owner May 5, 2025 17:08
@samtrion samtrion requested review from Dakraid and removed request for a team May 5, 2025 17:08
@samtrion samtrion force-pushed the development branch 2 times, most recently from 883ce94 to 34d0969 Compare May 5, 2025 17:12
@samtrion samtrion requested review from Copilot and removed request for Dakraid May 5, 2025 17:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new health check implementations and related dependency injection extensions for Azure Service Bus, Apache ActiveMq, AWS SNS, and a placeholder for Azure Cosmos.

  • Adds dependency injection extension classes and configuration for each messaging service.
  • Implements client creation factories and health check execution logic for the targeted services.
  • Introduces options and configuration classes to manage connection settings and behavior.

Reviewed Changes

Copilot reviewed 63 out of 69 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/NetEvolve.HealthChecks.Azure.ServiceBus/DependencyInjectionExtensions.cs Adds Azure Service Bus health check registration and default tags using modern C# array initialization syntax.
src/NetEvolve.HealthChecks.Azure.ServiceBus/ClientCreationMode.cs Introduces an enum to represent client creation modes for Azure Service Bus.
src/NetEvolve.HealthChecks.Azure.ServiceBus/ClientCreation.cs Provides client creation and caching logic for Azure Service Bus clients.
src/NetEvolve.HealthChecks.Azure.Cosmos/Class1.cs Adds a placeholder class for Azure Cosmos.
src/NetEvolve.HealthChecks.Apache.ActiveMq/DependencyInjectionExtensions.cs Adds dependency injection extension for Apache ActiveMq health check with default tags.
src/NetEvolve.HealthChecks.Apache.ActiveMq/ClientFactory.cs Implements a client factory for Apache ActiveMq connections with asynchronous creation logic.
src/NetEvolve.HealthChecks.Apache.ActiveMq/ActiveMqOptions.cs Defines options for configuring the ActiveMq health check with custom property getters.
src/NetEvolve.HealthChecks.Apache.ActiveMq/ActiveMqHealthCheck.cs Implements the Apache ActiveMq health check using the client factory and timeout logic.
src/NetEvolve.HealthChecks.Apache.ActiveMq/ActiveMqConfigure.cs Provides configuration binding and validation for ActiveMq health check options.
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceOptions.cs Defines options for AWS SNS health check and client creation; contains a problematic region endpoint getter.
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceHealthCheck.cs Implements the AWS SNS health check logic using the client creation helper based on the provided options.
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceConfigure.cs Provides empty configuration and validation logic for AWS SNS health check options.
src/NetEvolve.HealthChecks.AWS.SNS/DependencyInjectionExtensions.cs Adds dependency injection extension for AWS SNS health check registration with default tags.
src/NetEvolve.HealthChecks.AWS.SNS/CreationMode.cs Introduces an enum for AWS SNS client creation mode.
Files not reviewed (6)
  • Directory.Packages.props: Language not supported
  • HealthChecks.sln: Language not supported
  • src/NetEvolve.HealthChecks.AWS.SNS/NetEvolve.HealthChecks.AWS.SNS.csproj: Language not supported
  • src/NetEvolve.HealthChecks.Apache.ActiveMq/NetEvolve.HealthChecks.Apache.ActiveMq.csproj: Language not supported
  • src/NetEvolve.HealthChecks.Apache.Kafka/NetEvolve.HealthChecks.Apache.Kafka.csproj: Language not supported
  • src/NetEvolve.HealthChecks.Azure.Cosmos/NetEvolve.HealthChecks.Azure.Cosmos.csproj: Language not supported

@samtrion samtrion changed the title [WIP] feat: Apache ActiveMq, AWS.SNS and Azure CosmosDb and ServiceBus 🚧 feat: Apache ActiveMq, AWS.SNS and Azure CosmosDb and ServiceBus May 5, 2025
@samtrion samtrion force-pushed the development branch 3 times, most recently from 31fafb5 to 1b77579 Compare May 12, 2025 19:49
@samtrion samtrion force-pushed the development branch 3 times, most recently from c5c6c6e to 1748bb2 Compare May 22, 2025 18:49
@samtrion samtrion requested a review from Copilot May 22, 2025 18:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new health check implementations and improvements for Apache ActiveMQ and AWS SNS, and updates existing health check types and project configurations. Key changes include refactoring option classes into records, adding dependency injection extensions for new health check providers, and updating project/package metadata.

Reviewed Changes

Copilot reviewed 156 out of 156 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/NetEvolve.HealthChecks.Azure.Blobs/BlobContainerAvailableOptions.cs Changed class to record and updated Mode property to nullable.
src/NetEvolve.HealthChecks.Apache.Kafka/README.md Fixed a spelling error in the documentation.
src/NetEvolve.HealthChecks.Apache.Kafka/KafkaOptions.cs Converted class to record.
src/NetEvolve.HealthChecks.Apache.ActiveMq/*.csproj, DependencyInjectionExtensions.cs Added new health check project and DI extensions for ActiveMQ.
src/NetEvolve.HealthChecks.AWS.SNS/*.cs Added new health check implementation and configuration for AWS SNS.
Directory.Packages.props / Directory.Build.props Updated dependency versions and target framework.

@samtrion samtrion changed the title 🚧 feat: Apache ActiveMq, AWS.SNS and Azure CosmosDb and ServiceBus 🚧 feat: Apache ActiveMq, AWS.SNS, Azure.CosmosDb, Azure.ServiceBus, Firebird May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 96.70588% with 14 lines in your changes missing coverage. Please review.

Project coverage is 98.96%. Comparing base (3000d17) to head (27eaa87).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ks.AWS.SNS/SimpleNotificationServiceHealthCheck.cs 87.50% 5 Missing ⚠️
...cks.Azure.ServiceBus/ServiceBusQueueHealthCheck.cs 89.47% 2 Missing ⚠️
...re.ServiceBus/ServiceBusSubscriptionHealthCheck.cs 89.47% 2 Missing ⚠️
...cks.Azure.ServiceBus/ServiceBusTopicHealthCheck.cs 75.00% 2 Missing ⚠️
...zure.ServiceBus/ServiceBusTopicOptionsConfigure.cs 81.81% 2 Missing ⚠️
...ecks.AWS.SNS/SimpleNotificationServiceConfigure.cs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   98.70%   98.96%   +0.26%     
==========================================
  Files          79      108      +29     
  Lines        1390     1841     +451     
  Branches      249      326      +77     
==========================================
+ Hits         1372     1822     +450     
- Misses         18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samtrion samtrion changed the title 🚧 feat: Apache ActiveMq, AWS.SNS, Azure.CosmosDb, Azure.ServiceBus, Firebird 🚧 feat: Apache ActiveMq, AWS.SNS, Azure.ServiceBus, Firebird May 22, 2025
@samtrion samtrion requested a review from Copilot May 23, 2025 22:14
Copy link

@samtrion samtrion changed the title 🚧 feat: Apache.ActiveMq, AWS.SNS, Azure.ServiceBus, Firebird feat: Apache.ActiveMq, AWS.SNS, Azure.ServiceBus, Firebird May 26, 2025
@samtrion samtrion merged commit 4deed14 into main May 26, 2025
16 of 17 checks passed
@samtrion samtrion deleted the development branch May 26, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Indicates a new feature or enhancement to be added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetEvolve.HealthChecks.Firebird NetEvolve.HealthChecks.Apache.ActiveMQ NetEvolve.HealthChecks.AWS.SNS NetEvolve.HealthChecks.Azure.ServiceBus
2 participants