-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Apache.ActiveMq, AWS.SNS, Azure.ServiceBus, Firebird #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
883ce94
to
34d0969
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new health check implementations and related dependency injection extensions for Azure Service Bus, Apache ActiveMq, AWS SNS, and a placeholder for Azure Cosmos.
- Adds dependency injection extension classes and configuration for each messaging service.
- Implements client creation factories and health check execution logic for the targeted services.
- Introduces options and configuration classes to manage connection settings and behavior.
Reviewed Changes
Copilot reviewed 63 out of 69 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/NetEvolve.HealthChecks.Azure.ServiceBus/DependencyInjectionExtensions.cs | Adds Azure Service Bus health check registration and default tags using modern C# array initialization syntax. |
src/NetEvolve.HealthChecks.Azure.ServiceBus/ClientCreationMode.cs | Introduces an enum to represent client creation modes for Azure Service Bus. |
src/NetEvolve.HealthChecks.Azure.ServiceBus/ClientCreation.cs | Provides client creation and caching logic for Azure Service Bus clients. |
src/NetEvolve.HealthChecks.Azure.Cosmos/Class1.cs | Adds a placeholder class for Azure Cosmos. |
src/NetEvolve.HealthChecks.Apache.ActiveMq/DependencyInjectionExtensions.cs | Adds dependency injection extension for Apache ActiveMq health check with default tags. |
src/NetEvolve.HealthChecks.Apache.ActiveMq/ClientFactory.cs | Implements a client factory for Apache ActiveMq connections with asynchronous creation logic. |
src/NetEvolve.HealthChecks.Apache.ActiveMq/ActiveMqOptions.cs | Defines options for configuring the ActiveMq health check with custom property getters. |
src/NetEvolve.HealthChecks.Apache.ActiveMq/ActiveMqHealthCheck.cs | Implements the Apache ActiveMq health check using the client factory and timeout logic. |
src/NetEvolve.HealthChecks.Apache.ActiveMq/ActiveMqConfigure.cs | Provides configuration binding and validation for ActiveMq health check options. |
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceOptions.cs | Defines options for AWS SNS health check and client creation; contains a problematic region endpoint getter. |
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceHealthCheck.cs | Implements the AWS SNS health check logic using the client creation helper based on the provided options. |
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceConfigure.cs | Provides empty configuration and validation logic for AWS SNS health check options. |
src/NetEvolve.HealthChecks.AWS.SNS/DependencyInjectionExtensions.cs | Adds dependency injection extension for AWS SNS health check registration with default tags. |
src/NetEvolve.HealthChecks.AWS.SNS/CreationMode.cs | Introduces an enum for AWS SNS client creation mode. |
Files not reviewed (6)
- Directory.Packages.props: Language not supported
- HealthChecks.sln: Language not supported
- src/NetEvolve.HealthChecks.AWS.SNS/NetEvolve.HealthChecks.AWS.SNS.csproj: Language not supported
- src/NetEvolve.HealthChecks.Apache.ActiveMq/NetEvolve.HealthChecks.Apache.ActiveMq.csproj: Language not supported
- src/NetEvolve.HealthChecks.Apache.Kafka/NetEvolve.HealthChecks.Apache.Kafka.csproj: Language not supported
- src/NetEvolve.HealthChecks.Azure.Cosmos/NetEvolve.HealthChecks.Azure.Cosmos.csproj: Language not supported
src/NetEvolve.HealthChecks.AWS.SNS/SimpleNotificationServiceOptions.cs
Outdated
Show resolved
Hide resolved
31fafb5
to
1b77579
Compare
c5c6c6e
to
1748bb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new health check implementations and improvements for Apache ActiveMQ and AWS SNS, and updates existing health check types and project configurations. Key changes include refactoring option classes into records, adding dependency injection extensions for new health check providers, and updating project/package metadata.
Reviewed Changes
Copilot reviewed 156 out of 156 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/NetEvolve.HealthChecks.Azure.Blobs/BlobContainerAvailableOptions.cs | Changed class to record and updated Mode property to nullable. |
src/NetEvolve.HealthChecks.Apache.Kafka/README.md | Fixed a spelling error in the documentation. |
src/NetEvolve.HealthChecks.Apache.Kafka/KafkaOptions.cs | Converted class to record. |
src/NetEvolve.HealthChecks.Apache.ActiveMq/*.csproj, DependencyInjectionExtensions.cs | Added new health check project and DI extensions for ActiveMQ. |
src/NetEvolve.HealthChecks.AWS.SNS/*.cs | Added new health check implementation and configuration for AWS SNS. |
Directory.Packages.props / Directory.Build.props | Updated dependency versions and target framework. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 98.70% 98.96% +0.26%
==========================================
Files 79 108 +29
Lines 1390 1841 +451
Branches 249 326 +77
==========================================
+ Hits 1372 1822 +450
- Misses 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Martin Stühmer <[email protected]>
|
Closed: #54
Closed: #41
Closed: #57
Closed: #704