Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop -> Master #14

Merged
merged 24 commits into from
Sep 19, 2024
Merged

Develop -> Master #14

merged 24 commits into from
Sep 19, 2024

Conversation

daksh7011
Copy link
Owner

@daksh7011 daksh7011 commented Aug 30, 2024

Description

Merge commits from develop to master

Type of change

  • N/A (Check commit log)

How Has This Been Tested?

Individual PRs tests the changes pushed in develop, So Testing is only limited to CI passing on this PR.

Checklist:

  • N/A (this is not needed for this PR since all PR targeting develop already does these checks)

Summary by Sourcery

Merge changes from the develop branch to master, including updates to the Gradle wrapper script, library version upgrades, CI workflow improvements, and documentation enhancements such as a new code of conduct and pull request template.

Enhancements:

  • Update Gradle wrapper script to improve error handling and output redirection.
  • Update library versions in gradle/libs.versions.toml for detekt, kx-ser, logback, unleash, and kmongo-coroutine.
  • Update Qodana GitHub Action to a newer version in the CI workflow.

Documentation:

  • Update README.md to reflect changes in repository links and license information.
  • Add a new CODE_OF_CONDUCT.md file to establish community guidelines.
  • Add a pull request template to standardize contributions.

Copy link

sourcery-ai bot commented Aug 30, 2024

Reviewer's Guide by Sourcery

This pull request merges changes from the develop branch to the master branch. The changes include updating library dependencies, adding new community-related files, and modifying existing files to reflect repository migration and license details. The implementation focuses on updating version numbers, adding new files, and adjusting existing content to align with the project's current state and community standards.

File-Level Changes

Change Details Files
Update library dependencies and Gradle configuration
  • Update detekt version from 1.23.6 to 1.23.7
  • Update kx-ser version from 1.7.1 to 1.7.2
  • Update logback version from 1.5.7 to 1.5.8
  • Update unleash version from 8.4.0 to 9.2.4
  • Update kmongo-coroutine version from 4.11.0 to 5.1.0
  • Update Qodana action version from v2024.1.9 to v2024.2.2
gradle/libs.versions.toml
settings.gradle.kts
.github/workflows/qodana_code_quality.yml
Add community-related files
  • Add Contributor Covenant Code of Conduct
  • Add pull request template with guidelines for contributors
CODE_OF_CONDUCT.md
.github/pull_request_template.md
Update README.md to reflect repository migration and license details
  • Update repository links from GitLab to GitHub
  • Update license section with detailed terms of the MIT license
  • Update copyright year to 2024
README.md
Modify Gradle wrapper script for Windows
  • Add SPDX license identifier
  • Improve error handling and output
  • Update exit code handling
gradlew.bat

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daksh7011 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

github-actions bot commented Aug 30, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@daksh7011
Copy link
Owner Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daksh7011 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.


Troy is available under terms of MIT license.
Copyright (c) 2024 TechnoWolf FOSS
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): Check the copyright year

The copyright year is set to 2024, which is in the future. Consider updating this to the current year or the year of the project's inception.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current year is 2024 already. 😆

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback, we will generate more comments like this in the future according to the following instructions:

- Ensure the comment addresses a specific issue or improvement in the code or documentation.
- Verify that the comment provides a clear and actionable suggestion or correction.
- Check that the comment is relevant to the current state of the code or documentation.
- Confirm that the comment is written in a professional and constructive manner.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see the suggested change. It is not necessary to add a year in the README license block. It is alright as is.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback, we will generate fewer comments like this in the future according to the following instructions:

- Ensure comments address current issues or improvements relevant to the code or documentation.
- Avoid comments that point out issues not directly related to the current state or functionality, such as future dates that do not impact the present use or understanding.
- Focus on comments that provide actionable feedback or suggestions for immediate improvement.

Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@daksh7011 daksh7011 merged commit 062dbba into master Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant