Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unpacked kwargs from FigureCanvasAgg.print_png per Matplotlib 3.3 changes #44

Conversation

absurd
Copy link
Contributor

@absurd absurd commented Apr 28, 2021

Kwargs are still being applied via ItermplotCanvasMixin.before_print

Resolves #43

@djnym
Copy link
Contributor

djnym commented Jul 6, 2021

@daleroberts any chance this will be merged, and maybe the change I mentioned in #33 could also be fixed and pushed to pypi? I like the tool and want to use it but I currently have to fix these manually after installing into a virtualenv.

@daleroberts
Copy link
Owner

daleroberts commented Jul 7, 2021 via email

@daleroberts daleroberts merged commit 65f2871 into daleroberts:master Jul 7, 2021
@daleroberts
Copy link
Owner

Thanks for the pull request

@daleroberts
Copy link
Owner

pip install itermplot==0.4

@absurd absurd deleted the issue43-figurecanvasagg-print-png-kwargs-deprecation branch July 7, 2021 03:49
@rfabbri
Copy link

rfabbri commented Oct 29, 2023

The README still has pip3 install itermplot in the install section even though the beginning of the file it mentions the correct pip install itermplot==0.5. Fixing that would help. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning messages re. deprecation of FigureCanvasAgg.print_png kwargs
4 participants