chore: fixed code smells

README.md

@@ -1,6 +1,6 @@
-<p style="text-align: center"><a href="https://danielduarte.github.io/flowed/"><img width="445" height="100" src="./doc/flowed-logo.svg" alt="Flowed Logo"></a></p>
-<p style="text-align: center">A fast and reliable flow engine for orchestration and more uses in <em>Node.js</em>, <em>Deno</em> and the browser.</p>
-<p style="text-align: center">
+<p align="center"><a href="https://danielduarte.github.io/flowed/"><img width="445" height="100" src="./doc/flowed-logo.svg" alt="Flowed Logo"></a></p>
+<p align="center">A fast and reliable flow engine for orchestration and more uses in <em>Node.js</em>, <em>Deno</em> and the browser.</p>
+<p align="center">
     <a href="https://github.com/danielduarte/flowed/blob/main/LICENSE"><img src="https://img.shields.io/npm/l/flowed?color=%23007ec6" alt="License"></a>
     <a href="https://www.npmjs.com/package/flowed"><img src="https://img.shields.io/npm/v/flowed" alt="NPM Package Version"></a>
     <a href="https://app.fossa.com/attribution/e587cd9b-f7f8-4fa6-88b1-f81832d9ce07"><img src="https://app.fossa.com/api/projects/custom%2B13599%2Fgithub.com%2Fdanielduarte%2Fflowed.svg?type=shield" alt="FOSSA Status"></a>

src/engine/flow-run-status.ts

@@ -104,7 +104,8 @@ export class FlowRunStatus {
     // To be used later to check if expectedResults can be fulfilled.
     this.taskProvisions = Array.from(new Set(provisions));
 
-    this.options = Object.assign({}, this.spec.configs ?? {}, this.spec.options ?? {});
+    this.options = { ...this.spec.configs, ...this.spec.options };
+
     if (Object.prototype.hasOwnProperty.call(this.spec, 'configs')) {
       this.flow.log({ m: "DEPRECATED: 'configs' field in flow spec. Use 'options' instead.", l: 'w' });
     }
@@ -174,7 +175,7 @@ export class FlowRunStatus {
       taskStatuses: {},
     };
 
-    const serializableContext = Object.assign({}, this.context);
+    const serializableContext = { ...this.context };
     delete serializableContext.$flowed;
     serialized.context = JSON.parse(JSON.stringify(serializableContext));
 

src/engine/flow-state/flow-state.ts

@@ -365,10 +365,10 @@ export abstract class FlowState implements IFlow {
   public static formatDebugMessage({ n, m, l, e }: { n?: number; m: string; mp?: ValueMap; l?: string; e?: string }): string {
     const levelIcon = l === 'w' ? '⚠️ ' : '';
     const eventIcons = { FS: '▶ ', FF: '✔ ', TS: '  ‣ ', TF: '  ✓ ', FC: '  ⓘ ', FT: '◼ ', FP: '⏸ ' };
-    let eventIcon = (eventIcons as any)[e || ''] ?? ''; // eslint-disable-line @typescript-eslint/no-explicit-any
-    if (e === 'TF' && ['e', 'f'].includes(l || '')) {
+    let eventIcon = (eventIcons as any)[e ?? ''] ?? ''; // eslint-disable-line @typescript-eslint/no-explicit-any
+    if (e === 'TF' && ['e', 'f'].includes(l ?? '')) {
       eventIcon = '  ✗';
-    } else if (e === 'FF' && ['e', 'f'].includes(l || '')) {
+    } else if (e === 'FF' && ['e', 'f'].includes(l ?? '')) {
       eventIcon = '✘';
     }
     const icon = levelIcon + eventIcon;

test/edge-cases.ts

@@ -1,6 +1,5 @@
 import { expect } from 'chai';
-import { FlowManager, ValueMap } from '../src';
-import { Task } from '../src';
+import { FlowManager, ValueMap, Task } from '../src';
 
 describe('edge cases', () => {
   it('manually provide unexpected requirement to task must throw an error', async () => {

test/examples-inline/microservices.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from '../examples/types';
 
 const callMicroservice = (params: ValueMap) => {
@@ -23,7 +22,7 @@ const callMicroservice = (params: ValueMap) => {
 };
 
 const simpleMerge = (params: ValueMap) => ({
-  result: Object.assign({}, params.obj1, params.obj2),
+  result: {  ...params.obj1, ...params.obj2 },
 });
 
 // noinspection JSUnusedGlobalSymbols

test/examples-inline/pythagoras.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from '../examples/types';
 
 // Example of named function used as resolver

test/examples/apparent-circular-deps.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from './types';
 
 class DummyResolver {

test/examples/dependencies.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from './types';
 
 class DummyResolver {

test/examples/microservices.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from './types';
 
 class CallMicroservice {
@@ -27,7 +26,7 @@ class CallMicroservice {
 class SimpleMerge {
   public async exec(params: ValueMap): Promise<ValueMap> {
     return {
-      result: Object.assign({}, params.obj1, params.obj2),
+      result: { ...params.obj1, ...params.obj2 },
     };
   }
 }

test/examples/pythagoras.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from './types';
 
 class Sqr {

test/examples/sync-async.ts

@@ -1,5 +1,4 @@
-import { ValueMap } from '../../src';
-import { FlowManager } from '../../src';
+import { ValueMap, FlowManager } from '../../src';
 import { ExampleFunction } from './types';
 
 class TimerResolver {

test/flow-manager.ts

@@ -1,7 +1,5 @@
 import { expect } from 'chai';
-import { TaskResolverMap, ValueMap } from '../src';
-import { FlowManager } from '../src';
-import { FlowSpec } from '../src';
+import { TaskResolverMap, ValueMap, FlowManager, FlowSpec } from '../src';
 
 class DummyResolver {
   public async exec(): Promise<ValueMap> {

test/flow-pausing.ts

@@ -1,7 +1,6 @@
 import { expect } from 'chai';
 import rawDebug from '../src/debug';
-import { ValueMap } from '../src';
-import { Flow, Task } from '../src';
+import { ValueMap, Flow, Task } from '../src';
 const debug = rawDebug('test');
 
 describe('the flow', () => {

test/flow-stopping.ts

@@ -1,6 +1,5 @@
 import { expect } from 'chai';
-import { ValueMap } from '../src';
-import { Flow, Task } from '../src';
+import { ValueMap, Flow, Task } from '../src';
 
 describe('the flow', () => {
   const text1 = '(text1)';

test/resolver-library-builtin.ts

@@ -1,6 +1,5 @@
 import { expect } from 'chai';
-import { ValueMap } from '../src';
-import { FlowManager } from '../src';
+import { ValueMap, FlowManager } from '../src';
 
 describe('the ResolverLibrary', () => {
   it('runs noop resolver without mapping', () => {

test/resolver-library.ts

@@ -1,8 +1,6 @@
 import { expect } from 'chai';
-import { Task, ValueMap, WaitResolver } from '../src';
-import { FlowManager } from '../src';
+import { Task, ValueMap, WaitResolver, FlowManager, TaskResolver } from '../src';
 import * as ResolverLibrary from '../src/resolver-library';
-import { TaskResolver } from '../src';
 import rawDebug from '../src/debug';
 const debug = rawDebug('test');
 

test/serialization.ts

@@ -1,7 +1,6 @@
 import { expect } from 'chai';
 import rawDebug from '../src/debug';
-import { Flow, ValueMap } from '../src';
-import { Task } from '../src';
+import { Flow, ValueMap, Task } from '../src';
 const debug = rawDebug('test');
 
 describe('a flow state can be', () => {

test/task-repeater.ts

@@ -1,7 +1,6 @@
 import { expect } from 'chai';
 import rawDebug from '../src/debug';
-import { ValueMap } from '../src';
-import { FlowManager } from '../src';
+import { ValueMap, FlowManager } from '../src';
 import * as ResolverLibrary from '../src/resolver-library';
 const debug = rawDebug('test');