This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Fix broken comment references #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lrhn
approved these changes
Oct 13, 2023
lib/src/characters.dart
Outdated
| /// using [CharacterRange.movePrevious], | ||
| /// as well as controlling the iteration in more detail. | ||
| /// Allows iterating the characters of [string] backwards using | ||
| /// [CharacterRange.moveBack], as well as controlling the iteration in more |
There was a problem hiding this comment.
I'd still keep the line break after the comma, instead of splitting the following clause on two lines.
| /// Uses information stored in [_state] for cases where the next | ||
| /// character has already been seen. | ||
| /// Uses information stored in the state for cases where the next character | ||
| /// has already been seen. |
There was a problem hiding this comment.
I'm not even sure which state that is. Maybe the entire paragraph is garbage.
|
As a drive by comment, if we update the dep on |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 14, 2024
* Fix broken comment references * feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These broken comment references are all highlighted by the
comment_referenceslinter rule, and thedart doctool.In a few cases, I tried to find a replacement, but I also had to just abandon some
[]references as I could not tell what the current equivalent is, for what they (presumably) previously referred to.Let me know if there is better replacement text. Let me know if I should bump the version in CHANGELOG and pubspec files.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.