Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Fix broken comment references #89

Merged
merged 2 commits into from
Oct 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.dart_tool/
.packages
pubspec.lock
doc/api/
11 changes: 5 additions & 6 deletions lib/src/characters.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ abstract class Characters implements Iterable<String> {
/// Returns [CharacterRange] positioned after the last character
/// of this [Characters].
///
/// Allows iterating the characters of [string] backwards
/// using [CharacterRange.movePrevious],
/// as well as controlling the iteration in more detail.
/// Allows iterating the characters of [string] backwards using
/// [CharacterRange.moveBack], as well as controlling the iteration in more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still keep the line break after the comma, instead of splitting the following clause on two lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

/// detail.
CharacterRange get iteratorAtEnd;

/// Whether [singleCharacterString] occurs in this
Expand All @@ -62,7 +62,7 @@ abstract class Characters implements Iterable<String> {
/// and that character is one of the characters
/// in this character sequence, and false otherwise.
/// This behavior is inherited from `Iterable<String>`,
/// which is why it is not [Character] based.
/// which is why it is not [Characters]-based.
/// Use [containsAll] for a method which acts like
/// [String.contains] for characters.
@override
Expand Down Expand Up @@ -390,8 +390,7 @@ abstract class CharacterRange implements Iterator<String> {
/// The copy is in the exact same state as this iterator.
/// Can be used to iterate the following characters more than once
/// at the same time. To simply rewind an iterator, remember the
/// [start] or [end] position and use [reset] to reset the iterator
/// to that position.
/// start or end position and use reset the iterator to that position.
CharacterRange copy();

/// Whether the current range is empty.
Expand Down
6 changes: 3 additions & 3 deletions lib/src/characters_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -464,15 +464,15 @@ class StringCharacterRange implements CharacterRange {

/// Creates a [Breaks] from [_end] to `_string.length`.
///
/// Uses information stored in [_state] for cases where the next
/// character has already been seen.
/// Uses information stored in the state for cases where the next character
/// has already been seen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure which state that is. Maybe the entire paragraph is garbage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

Breaks _breaksFromEnd() {
return Breaks(_string, _end, _string.length, stateSoTNoBreak);
}

/// Creates a [Breaks] from string start to [_start].
///
/// Uses information stored in [_state] for cases where the previous
/// Uses information stored in the state for cases where the previous
/// character has already been seen.
BackBreaks _backBreaksFromStart() {
return BackBreaks(_string, _start, 0, stateEoTNoBreak);
Expand Down
2 changes: 1 addition & 1 deletion tool/src/atsp.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

/// An asymmetric weighted complete graph.
///
/// The vertices are identified by numbers 0 through [vertices] - 1.
/// The vertices are identified by numbers 0 through [vertexCount] - 1.
/// Edges are pairs of vertices.
class Graph {
/// Number of vertices.
Expand Down