improve testing of the 'dart fix' data #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we reduced the number of generated APIs we stopped generating some classes referenced in the
lib/fix_data.yaml
file. Our testing didn't catch this, since the runningdart fix --compare-to-golden
just mechanically confirms that it can transform the file, not whether the resulting file is error free.This PR creates a new temporary project with the
test_fixes/renames.dart
file - which contains the older dart:html type names - runsdart fix
on that project, to update the references to the new package:web names, and runsdart analyze
to make sure the result has no analysis issues.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.