-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve testing of the 'dart fix' data #166
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| @TestOn('vm') | ||
| library; | ||
|
|
||
| import 'dart:io'; | ||
|
|
||
| import 'package:path/path.dart' as p; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| // Used for debugging the test. | ||
| const keepTempDir = false; | ||
|
|
||
| void main() { | ||
| test("'dart fix' integration", () { | ||
| // create temp dir | ||
| final tempDir = Directory.systemTemp.createTempSync('test'); | ||
|
|
||
| var sdkVersion = Platform.version; | ||
| if (sdkVersion.contains(' ')) { | ||
| sdkVersion = sdkVersion.substring(0, sdkVersion.indexOf(' ')); | ||
| } | ||
|
|
||
| try { | ||
| // set up project | ||
| writeFile(tempDir, 'pubspec.yaml', ''' | ||
| name: test_project | ||
| environment: | ||
| sdk: '^$sdkVersion' | ||
| dependencies: | ||
| web: | ||
| path: ${Directory.current.path} | ||
| '''); | ||
| final sourceFile = File(p.join('test_fixes', 'renames.dart')); | ||
| writeFile( | ||
| tempDir, | ||
| p.join('lib', sourceFile.name), | ||
| sourceFile.readAsStringSync(), | ||
| ); | ||
|
|
||
| // run pub get | ||
| pubGet(tempDir); | ||
|
|
||
| // dart fix | ||
| dartFix(tempDir); | ||
|
|
||
| // verify no analysis issues | ||
| dartAnalyze(tempDir); | ||
| } finally { | ||
| // ignore: dead_code | ||
| if (keepTempDir) { | ||
| print('dart fix test temp dir: ${tempDir.path}'); | ||
| } else { | ||
| tempDir.deleteSync(recursive: true); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| void writeFile(Directory dir, String filePath, String contents) { | ||
| final file = File(p.join(dir.path, filePath)); | ||
| file.parent.createSync(); | ||
| file.writeAsStringSync(contents); | ||
| } | ||
|
|
||
| void pubGet(Directory dir) { | ||
| exec('pub', ['get'], cwd: dir); | ||
| } | ||
|
|
||
| void dartFix(Directory dir) { | ||
| exec('fix', ['--apply'], cwd: dir); | ||
| } | ||
|
|
||
| void dartAnalyze(Directory dir) { | ||
| exec('analyze', [], cwd: dir); | ||
| } | ||
|
|
||
| void exec(String command, List<String> args, {required Directory cwd}) { | ||
| printOnFailure('dart $command ${args.join(', ')}'); | ||
|
|
||
| final result = Process.runSync( | ||
| Platform.resolvedExecutable, | ||
| [command, ...args], | ||
| workingDirectory: cwd.path, | ||
| ); | ||
|
|
||
| var out = result.stdout as String; | ||
| if (out.isNotEmpty) printOnFailure(out); | ||
| out = result.stderr as String; | ||
| if (out.isNotEmpty) printOnFailure(out); | ||
|
|
||
| if (result.exitCode != 0) { | ||
| fail('dart $command: exitCode ${result.exitCode}'); | ||
| } | ||
| } | ||
|
|
||
| extension on File { | ||
| String get name => p.basename(path); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this lint. How'd you hit it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
test_fixes/renames.dartfile (which to be honest isn't really intended to be best practice dart code). From memory, I've also hit it a few other times where it was false positives.