feat: serialize on the stack #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2023
knst
requested changes
May 16, 2023
| uint8_t buffer[G1Element::SIZE + 1]; | ||
| g1_write_bin(buffer, G1Element::SIZE + 1, p, 1); | ||
|
|
||
| if (buffer[0] == 0x00) { // infinity |
There was a problem hiding this comment.
Implementation of G1Element::Serialize and G1Element::SerializeToArray 90% same and basically code-paste...
Can you refactor it to use some util method or call functions from each of other?
There was a problem hiding this comment.
I think this one will work fine:
std::vector<uint8_t> G1Element::Serialize(const bool fLegacy) const {
const auto arr = G1Element::SerializeToArray(fLegacy);
return std::vector<uint8_t>{arr.begin(), arr.end()};
}
| @@ -405,6 +444,44 @@ std::vector<uint8_t> G2Element::Serialize(const bool fLegacy) const { | |||
| return result; | |||
| } | |||
|
|
|||
| std::array<uint8_t, G2Element::SIZE> G2Element::SerializeToArray(const bool fLegacy) const { | |||
There was a problem hiding this comment.
code duplication with G2Element::Serialize()
| @@ -534,4 +611,11 @@ std::vector<uint8_t> GTElement::Serialize() const | |||
| return data; | |||
| } | |||
|
|
|||
| std::array<uint8_t, GTElement::SIZE> GTElement::SerializeToArray() const | |||
| { | |||
| std::array<uint8_t, GTElement::SIZE> data{}; | |||
There was a problem hiding this comment.
better to initialize data, then let it potentially be uninitialized
|
'This PR has been flagged as stale due to no activity for over 60 |
PastaPastaPasta
force-pushed
the
feat/serialize-stack
branch
from
8a2086e
to
2efa4f2
Compare
PastaPastaPasta
force-pushed
the
feat/serialize-stack
branch
from
2efa4f2
to
0f3705b
Compare
UdjinM6
reviewed
Dec 4, 2024
|
All done |
UdjinM6
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #74 to enhance library performance when integrated into other stuff