-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jlab3 #162
Jlab3 #162
Conversation
TODO either here or in a follow-up:
|
I am happy to take on this piece. Possibly in a separate PR? |
Great, thanks @jacobtomlinson! |
Update github workflows to run the full tests.
Okay, I think this is pretty close to ready, in case @jsignell or @jacobtomlinson want to take a look through. I have not done anything with auto-deploy, but I have mostly moved over to github actions from travis here (fixing #155 ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking this on! I looked it over and it seems good to me. Might be a good idea to update the README in this PR.
HERE = os.path.abspath(os.path.dirname(__file__)) | ||
|
||
# The name of the project | ||
name="dask_labextension" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously super minor, but I'm surprised this passes black.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it only checks the dask_labextension
folder: https://github.com/ian-r-rose/dask-labextension/blob/jlab3/.github/workflows/python.yaml#L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black
/flake8
have never actually been checked in CI for this repo. I've set it up here to do that, but left it disabled for now: https://github.com/ian-r-rose/dask-labextension/blob/283c1d1db31eb9d24e07e0c44796d97bc7d29ea2/.github/workflows/python.yaml#L37
I'd like to flip the switch here in a follow-up PR.
Checking in here. Is there anythign left to do on this? |
This is ready, I think. Once this is merged, the next steps are
|
Ok I'm happy to merge. @ian-r-rose are you happy to manually publish the RC and make the follow up to enable precommit checking? I'll handle the future PyPI automation in #155 |
Woo!
…On Tue, Jan 12, 2021 at 2:25 AM Jacob Tomlinson ***@***.***> wrote:
Merged #162 <#162> into
master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#162 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTARV6V5FK4JO5ZFHBLSZQPRRANCNFSM4VTIPI7Q>
.
|
I think we should update the README before releasing. |
Yes, I can do those
Thanks!
I agree, though I am going to try a pre-release to check if the reworked packaging is working as expected. |
Released conda create -n test python=3.8
conda activate test
pip install jupyterlab
pip install --pre dask-labextension |
Yes. This works swell for me.
…On Tue, Jan 12, 2021 at 11:03 AM Ian Rose ***@***.***> wrote:
Released 5.0.0rc0, I'd appreciate hearing if this works for folks (seemed
to do fine on my machine).
conda create -n test python=3.8
conda activate test
pip install jupyterlab
pip install --pre dask-labextension
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTDWQMBIURASSMH7TDLSZSMG5ANCNFSM4VTIPI7Q>
.
|
I've scheduled a tweet from the dask_dev account for this for tomorrow
morning. Does that schedule work for you?
…On Tue, Jan 12, 2021 at 11:03 AM Ian Rose ***@***.***> wrote:
Released 5.0.0rc0, I'd appreciate hearing if this works for folks (seemed
to do fine on my machine).
conda create -n test python=3.8
conda activate test
pip install jupyterlab
pip install --pre dask-labextension
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTDWQMBIURASSMH7TDLSZSMG5ANCNFSM4VTIPI7Q>
.
|
Sure, I need to figure out some weirdness with versioneer + PEP 517, and update the README, but I think those are reasonable to finish up this evening. |
Thanks Ian! Good to hear from you! |
Upgrades this extension to use JupyterLab 3. (superseding #154) This is a pretty major change in the packaging, though the changes to the codebase itself are pretty minor. In particular: