Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jlab3 #162

Merged
merged 13 commits into from
Jan 12, 2021
Merged

Jlab3 #162

merged 13 commits into from
Jan 12, 2021

Conversation

ian-r-rose
Copy link
Collaborator

@ian-r-rose ian-r-rose commented Jan 4, 2021

Upgrades this extension to use JupyterLab 3. (superseding #154) This is a pretty major change in the packaging, though the changes to the codebase itself are pretty minor. In particular:

  1. The JS assets can now be packaged and distributed using pypi/conda. This is a major improvement over requiring end-users to rebuild the application using webpack + node.
  2. Upgrades to TS 4.
  3. Replaces the deprecated tslint with eslint

@ian-r-rose
Copy link
Collaborator Author

TODO either here or in a follow-up:

@jacobtomlinson
Copy link
Member

Fix auto-deploy, probably updating to use gh actions

I am happy to take on this piece. Possibly in a separate PR?

@ian-r-rose
Copy link
Collaborator Author

I am happy to take on this piece. Possibly in a separate PR?

Great, thanks @jacobtomlinson!

@ian-r-rose
Copy link
Collaborator Author

Okay, I think this is pretty close to ready, in case @jsignell or @jacobtomlinson want to take a look through. I have not done anything with auto-deploy, but I have mostly moved over to github actions from travis here (fixing #155 ).

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking this on! I looked it over and it seems good to me. Might be a good idea to update the README in this PR.

HERE = os.path.abspath(os.path.dirname(__file__))

# The name of the project
name="dask_labextension"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously super minor, but I'm surprised this passes black.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black/flake8 have never actually been checked in CI for this repo. I've set it up here to do that, but left it disabled for now: https://github.com/ian-r-rose/dask-labextension/blob/283c1d1db31eb9d24e07e0c44796d97bc7d29ea2/.github/workflows/python.yaml#L37

I'd like to flip the switch here in a follow-up PR.

@mrocklin
Copy link
Member

Checking in here. Is there anythign left to do on this?

@ian-r-rose
Copy link
Collaborator Author

This is ready, I think. Once this is merged, the next steps are

  1. Manually publish an RC to pypi, check that it works
  2. Ensure that auto-deploy and conda-forge packages are updated (@jacobtomlinson said he could handle)
  3. Make a follow-up PR that enables black/flake8 here

@jacobtomlinson
Copy link
Member

Ok I'm happy to merge.

@ian-r-rose are you happy to manually publish the RC and make the follow up to enable precommit checking?

I'll handle the future PyPI automation in #155

@jacobtomlinson jacobtomlinson merged commit f273523 into dask:master Jan 12, 2021
@mrocklin
Copy link
Member

mrocklin commented Jan 12, 2021 via email

@jsignell
Copy link
Member

I think we should update the README before releasing.

@ian-r-rose
Copy link
Collaborator Author

@ian-r-rose are you happy to manually publish the RC and make the follow up to enable precommit checking?

Yes, I can do those

I'll handle the future PyPI automation in #155

Thanks!

I think we should update the README before releasing.

I agree, though I am going to try a pre-release to check if the reworked packaging is working as expected.

@ian-r-rose ian-r-rose mentioned this pull request Jan 12, 2021
@ian-r-rose
Copy link
Collaborator Author

Released 5.0.0rc0, I'd appreciate hearing if this works for folks (seemed to do fine on my machine).

conda create -n test python=3.8
conda activate test
pip install jupyterlab
pip install --pre dask-labextension

@mrocklin
Copy link
Member

mrocklin commented Jan 12, 2021 via email

@mrocklin
Copy link
Member

mrocklin commented Jan 12, 2021 via email

@ian-r-rose
Copy link
Collaborator Author

I've scheduled a tweet from the dask_dev account for this for tomorrow morning. Does that schedule work for you?

Sure, I need to figure out some weirdness with versioneer + PEP 517, and update the README, but I think those are reasonable to finish up this evening.

@jasongrout
Copy link

Thanks Ian! Good to hear from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants