-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CARDS-2580 - Number question: allow min/max value to be specified but not enforced #1810
base: dev
Are you sure you want to change the base?
Conversation
… not enforced Enable marckdown in validation messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… not enforced Addressing review comments - use the default message when min/max values are enforced.
When enforcing min/max is enabled, the error msg shows up:
This is due to the existing behavior, when error msg is blank and we display the old message. Can we just ignore the text in the error msg in this case ( when enforcing min/max is enabled)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
The code has been updated in 2bb40f1 to have the exact same behavior as before (no custom message). |
Includes a test questionnaire
Number Min / Max Value Test
.