Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARDS-2580 - Number question: allow min/max value to be specified but not enforced #1810

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

marta-
Copy link
Contributor

@marta- marta- commented Sep 18, 2024

Includes a test questionnaire Number Min / Max Value Test.

Copy link
Contributor

@sashaandjic sashaandjic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

image

Upon save, the form is not marked as Draft and Invalid if min/max are not enforced.

… not enforced

Addressing review comments - use the default message when min/max values are enforced.
@sashaandjic sashaandjic added bug Something isn't working and removed testing... Testing in progress labels Sep 18, 2024
@sashaandjic
Copy link
Contributor

sashaandjic commented Sep 18, 2024

When enforcing min/max is enabled, the error msg shows up:

  • in black fonts if withing the range
  • in red fonts of not within range

image

image

This is due to the existing behavior, when error msg is blank and we display the old message. Can we just ignore the text in the error msg in this case ( when enforcing min/max is enabled)?

@sashaandjic sashaandjic added testing... Testing in progress and removed bug Something isn't working labels Sep 18, 2024
Copy link
Contributor

@sashaandjic sashaandjic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@sashaandjic sashaandjic added tested Passed manual testing, needs code review and removed testing... Testing in progress labels Sep 18, 2024
@marta-
Copy link
Contributor Author

marta- commented Sep 18, 2024

When enforcing min/max is enabled, the error msg shows up:

  • in black fonts if withing the range
  • in red fonts of not within range

The code has been updated in 2bb40f1 to have the exact same behavior as before (no custom message).

@sashaandjic
Copy link
Contributor

sashaandjic commented Sep 18, 2024

image

It would be nice to always display range message below the input line.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested Passed manual testing, needs code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants