Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] apply make fmt-docs to all docs #4344

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[Doc] apply make fmt-docs to all docs #4344

merged 2 commits into from
Dec 23, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 23, 2024

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners December 23, 2024 08:39
@alexott alexott requested review from rauchy and removed request for a team December 23, 2024 08:39
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One small suggestion, otherwise LGTM.

name = "my-custom-app"
description = "My app"
name = "my-custom-app"
description = "My app"
resources = [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This first resource is less indented than the others, maybe due to some strange logic with the [ and { on the same line. Can you put a newline there and run it once more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a new line doesn't change the behavior. Also, I tested with putting the code into a terraform file and running terraform fmt on it - it's formatted it the same way as with fmt-docs

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4344
  • Commit SHA: a8e95a875d70b85ee818b3415d9ecbf96dc00c6b

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12466933490

@alexott alexott enabled auto-merge December 23, 2024 12:39
@alexott alexott added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 2b89282 Dec 23, 2024
12 checks passed
@alexott alexott deleted the docs/reformat-2024-12 branch December 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants