Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] apply make fmt-docs to all docs #4344

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[Doc] apply make fmt-docs to all docs #4344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa13b78
[Doc] apply `make fmt-docs` to all docs
alexott Dec 23, 2024
a8e95a8
Add a new line for app resources
alexott Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data-sources/app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This data source allows you to fetch information about a Databricks App.

```hcl
data "databricks_app" "this" {
name = "my-custom-app"
name = "my-custom-app"
}
```

Expand Down
2 changes: 1 addition & 1 deletion docs/data-sources/mws_network_connectivity_configs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ provider "databricks" {
}

data "databricks_mws_network_connectivity_configs" "this" {
region = "us-east-1"
region = "us-east-1"
}

output "filtered" {
Expand Down
2 changes: 1 addition & 1 deletion docs/data-sources/serving_endpoints.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ data "databricks_serving_endpoints" "all" {
}

resource "databricks_permissions" "ml_serving_usage" {
for_each = databricks_serving_endpoints.all.endpoints
for_each = databricks_serving_endpoints.all.endpoints
serving_endpoint_id = each.value.id

access_control {
Expand Down
35 changes: 18 additions & 17 deletions docs/resources/app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,29 @@ subcategory: "Apps"

```hcl
resource "databricks_app" "this" {
name = "my-custom-app"
description = "My app"
name = "my-custom-app"
description = "My app"

resources = [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This first resource is less indented than the others, maybe due to some strange logic with the [ and { on the same line. Can you put a newline there and run it once more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a new line doesn't change the behavior. Also, I tested with putting the code into a terraform file and running terraform fmt on it - it's formatted it the same way as with fmt-docs

name = "sql-warehouse"
sql_warehouse = {
id = "e9ca293f79a74b5c"
permission = "CAN_MANAGE"
}
},
{
name = "serving-endpoint"
serving_endpoint = {
name = "databricks-meta-llama-3-1-70b-instruct"
permission = "CAN_MANAGE"
}
},
{
name = "job"
job = {
id = "1234"
id = "e9ca293f79a74b5c"
permission = "CAN_MANAGE"
}
},
{
name = "serving-endpoint"
serving_endpoint = {
name = "databricks-meta-llama-3-1-70b-instruct"
permission = "CAN_MANAGE"
}
},
{
name = "job"
job = {
id = "1234"
permission = "CAN_MANAGE"
}
}]
}
```
Expand Down
14 changes: 7 additions & 7 deletions docs/resources/custom_app_integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ This resource allows you to enable [custom OAuth applications](https://docs.data

```hcl
resource "databricks_custom_app_integration" "this" {
name = "custom_integration_name"
redirect_urls = ["https://example.com"]
scopes = ["all-apis"]
token_access_policy {
access_token_ttl_in_minutes = 15
refresh_token_ttl_in_minutes = 30
}
name = "custom_integration_name"
redirect_urls = ["https://example.com"]
scopes = ["all-apis"]
token_access_policy {
access_token_ttl_in_minutes = 15
refresh_token_ttl_in_minutes = 30
}
}
```

Expand Down
4 changes: 2 additions & 2 deletions docs/resources/grant.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ See [databricks_grants Catalog grants](grants.md#catalog-grants) for the list of

```hcl
resource "databricks_catalog" "sandbox" {
name = "sandbox"
comment = "this catalog is managed by terraform"
name = "sandbox"
comment = "this catalog is managed by terraform"
properties = {
purpose = "testing"
}
Expand Down
4 changes: 2 additions & 2 deletions docs/resources/lakehouse_monitor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ resource "databricks_sql_table" "myTestTable" {
data_source_format = "DELTA"

column {
name = "timestamp"
type = "int"
name = "timestamp"
type = "int"
}
}

Expand Down
4 changes: 2 additions & 2 deletions docs/resources/quality_monitor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ resource "databricks_sql_table" "myTestTable" {
data_source_format = "DELTA"

column {
name = "timestamp"
type = "int"
name = "timestamp"
type = "int"
}
}

Expand Down
Loading