remove legacy jekyll template inclusion #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
|
Hi @cpauvert, thanks for your first pr! And sorry for the slow reply - @vhmcck and I are new maintainers and it has taken us a little while to get up to speed. And doing: is indeed a good way to check they lesson is building okay. Thanks again @cpauvert ! |
p-j-smith
approved these changes
Aug 14, 2023
|
Thank you for considering this : ) And good luck on your maintainers path! |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Auto-generated via {sandpaper}
Source : 394a20d
Branch : main
Author : Paul Smith <[email protected]>
Time : 2023-08-14 08:06:09 +0000
Message : Merge pull request #341 from cpauvert/fix-340-legacy-gh-variables
remove legacy jekyll template inclusion
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Auto-generated via {sandpaper}
Source : 35fdf61
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2023-08-14 08:08:53 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 394a20d
Branch : main
Author : Paul Smith <[email protected]>
Time : 2023-08-14 08:06:09 +0000
Message : Merge pull request #341 from cpauvert/fix-340-legacy-gh-variables
remove legacy jekyll template inclusion
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Auto-generated via {sandpaper}
Source : 35fdf61
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2023-08-14 08:08:53 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 394a20d
Branch : main
Author : Paul Smith <[email protected]>
Time : 2023-08-14 08:06:09 +0000
Message : Merge pull request #341 from cpauvert/fix-340-legacy-gh-variables
remove legacy jekyll template inclusion
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
Auto-generated via {sandpaper}
Source : 35fdf61
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2023-08-14 08:08:53 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 394a20d
Branch : main
Author : Paul Smith <[email protected]>
Time : 2023-08-14 08:06:09 +0000
Message : Merge pull request #341 from cpauvert/fix-340-legacy-gh-variables
remove legacy jekyll template inclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This fixes #340.
Removing the line improves readability and does not seem to break anything else in the lesson, after using the following command with the Carpentries Workbench:
Hope that helps and let me know if I should run additional tests to be sure not to break anything.
BEst,