Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninformative link spotted by sandpaper::validate_lesson() #342

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

cpauvert
Copy link
Contributor

@cpauvert cpauvert commented Jul 4, 2023

Hi,
Running the sandpaper::validate_lesson() for #341 spotted an uninformative link that I corrected.
Best,

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/shell-genomics/compare/md-outputs..md-outputs-PR-342

The following changes were observed in the rendered markdown documents:

 01-introduction.md | 3 +--
 md5sum.txt         | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-15 08:02:37 +0000

Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well spotted @cpauvert ! Just a couple of minor typos to fix

episodes/01-introduction.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@p-j-smith p-j-smith merged commit be769bd into datacarpentry:main Aug 15, 2023
3 checks passed
@p-j-smith
Copy link
Contributor

thanks again for fixing these warning @cpauvert!

github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
@cpauvert cpauvert deleted the fix-uninformative-link branch August 15, 2023 08:17
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
Auto-generated via {sandpaper}
Source  : 8692218
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-15 08:09:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : be769bd
Branch  : main
Author  : Charlie Pauvert <[email protected]>
Time    : 2023-08-15 08:08:10 +0000
Message : fix uninformative link spotted by `sandpaper::validate_lesson()` (#342)

* fix uninformative link spotted by `sandpaper::validate_lesson()`

* use the full name of the lesson in link to the notes of logging into remote servers

---------

Co-authored-by: Paul Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants