Pr/associativity of reductions #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Muhammad Awad <[email protected]>
Co-authored-by: Muhammad Awad <[email protected]>
Co-authored-by: James Dinan <[email protected]>
|
@davidozog AR: add an API note that reductions are not exactly associative... A future OpenSHMEM spec will clarify. WG folks like the idea of of adding support for a reduction API that DOES have well-defined ordering. |
|
@davidozog Let us push this to 1.7. My current understanding is that this may have some larger ramifications with respect to implementations today. I think for now leaving it up to the implementers to "fix" this may be better. |
4 tasks
Yes, at the last WG meeting it seemed consensus is to defer this for v1.7 - I will close this PR. We discussed a possible alternative: add a note that this issue will be clarified in a future version of the OpenSHMEM spec. That PR is prepared in #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This reopens #12 to target RC2.
The latest commit, 3519cfd addresses feedback from WG/committee reviews.
Proposal Checklist