reductions: add note about FP associativity #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we'd like to indicate this change is an erratum, that PR is now updated here: |
4 tasks
lstewart
reviewed
Oct 9, 2024
There was a problem hiding this comment.
In the API note, the proposal is going to be silent on statements like the following
- that the result should be the same on all PEs
- that the result should be the same if the operation is called multiple times on the same data during the same run
- that the result should be the same from run to run
- that the result may be different on different architectures, due to differing arithmetic
- that the result on IEEE-754 compatible platforms should always be the same everywhere and everywhen
- that we might consider new APIs or environment variables that enforce more consistent results
There was a problem hiding this comment.
This is a nice summary of the open issues. Can you capture it on the follow-up issue for OpenSHMEM 1.7 (and create said issue if we don't have one already)?
jdinan
reviewed
Oct 9, 2024
Co-authored-by: James Dinan <[email protected]>
jdinan
reviewed
Oct 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Regarding this issue:
https://github.com/orgs/openshmem-org/projects/5/views/1?pane=issue&itemId=74045800
The WG decided to defer something like PR #14, which adds the requirements regarding the reproducibilty of OpenSHMEM reductions on floating-point datatypes.
This PR briefly explains the issue in an API note, and says a future version of the specification may clarify the behavior of reductions on floating-point datatypes.
Proposal Checklist