[Collectives] Deprecate active based language #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo Co-authored-by: David Ozog <[email protected]>
White Space Co-authored-by: David Ozog <[email protected]>
Typo, uppercase
davidozog
reviewed
Aug 29, 2024
There was a problem hiding this comment.
I think we can take this on as a section edit for v1.6. After combing through, I only found 1 accidental semantic change regarding the team split stride value, everything else is just moving things around and appropriately wrapping text with deprecation markers.
It does bloat the length of the collectives sections a tiny bit, but also puts us in position to completely remove the deprecated text without any undesirable consequences (yay!). Maybe we remove in v1.7?
Co-authored-by: David Ozog <[email protected]>
davidozog
approved these changes
Aug 29, 2024
|
This closes openshmem-org#452 - looking for 1 more review w/ approval @maawad @BKP @isubsmith |
maawad
approved these changes
Aug 29, 2024
typo Co-authored-by: Muhammad Awad <[email protected]>
davidozog
approved these changes
Aug 30, 2024
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mirror of the PR on the main specification. Deprecates all blocks with active based collectives and creates new text with team based collectives.