Upgraded to dbt-core 1.4. #146

lpezet · 2023-04-21T21:14:37Z

resolves #122

Description

Upgrading to dbt-core 1.4:

now using field() from dataclasses package for policy fields definition. Consequently updated code to then use get_default_include_policy() to access class field
using DbtRuntimeError instead of RuntimeException
using FailedToConnectError instead of FailedToConnectException
using dbt.exceptions.DbtDatabaseError instead of dbt.exceptions.DatabaseException
updated requirements-dev.txt to use dbt-core 1.4.latest
using dbt.exceptions.CompilationError instead of deprecated dbt.exceptions.raise_compiler_error

Checklist

I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have updated the CHANGELOG.md with information about my change

lpezet · 2023-04-21T21:36:49Z

@dbeatty10 Not sure whether this project is still (even if sporadically) maintained but I'm in need to using dbt-mysql with dbt-core 1.4.
~~I'm having issues getting the docker-compose up and running (it starts but then each db says something is already running on their 3306 port) and I haven't figured out how to fix that yet.~~ All good now.
Having sait that, the following tests pass:

Unit tests
Functional tests for mysql, mysql5, and mariadb using docker-compose.

moszutij

It could be beneficial to substitute the deprecated function dbt.exceptions.raise_compiler_error with dbt.exceptions.CompilationError in the */impl.py files.

dbeatty10 · 2023-04-24T14:53:13Z

🚀 Thank you for your work here @lpezet !

I won't be able to spend time this week on reviewing this, but can give it a review next week.

…ceptions.CompilationError.

lpezet · 2023-04-24T17:23:57Z

@moszutij Thanks. I just made those changes. Weird my VSCode didn't catch those...
@dbeatty10 Awesome! Thx!

BamboOSZ · 2023-04-24T19:45:41Z

👀

wesen · 2023-05-08T15:40:59Z

I was just trying this one out @lpezet , and I think dbt.exceptions.DatabaseException needs to be updated to dbt.exceptions.DbtDatabaseError. I haven't done a deeper dive, just running my setup through it.

…tabaseException.

lpezet · 2023-05-08T18:53:13Z

@wesen Thanks. I'll fix those. My VSCode somehow is not showing those. If you have any good setup to share (linter, etc.) that would be great.

wesen · 2023-05-09T13:45:00Z

@lpezet I use intellij idea/pycharm, but in this case just saw it by... writing bad SQL :)

uraurora · 2023-06-10T08:38:19Z

Why this pr not being merged? Any progress now?

dbeatty10

Thank you @lpezet!

lucasfcnunes · 2023-08-22T13:27:52Z

I can't find the 1.4 release

outinim · 2023-11-08T09:25:49Z

Why is the 1.4 version is not linked to the main branch ? cc @dbeatty10 🙏🏼
What do you need to update the release ?

This reverts commit 3db05eb.

* Upgraded to dbt-core 1.4. * Updated CHANGELOG. * Fixed policy fields definitions for mariadb and mysql5. * Replaced deprecated dbt.exceptions.raise_compiler_error() with dbt.exceptions.CompilationError. * Now using dbt.exceptions.DbtDatabaseError insead of dbt.exceptions.DatabaseException. * Update version * Update changelog --------- Co-authored-by: Doug Beatty <[email protected]>

* Revert "Upgraded to dbt-core 1.4. (#146)" This reverts commit 3db05eb. * Fix version bumping * Migration bump2version (unmaintained) to bump-my-version * Import `bumpversion.cfg` from `dbt-snowflake` * Convert `bumpversion.cfg` to `bumpversion.toml` * Fix a few incorrect version labels * Remove macos and windows as integration targets * Fix requirements conflict between dbt 1.2 and tox * Bump version to 1.3 * Upgraded to dbt-core 1.4. (#146) * Upgraded to dbt-core 1.4. * Updated CHANGELOG. * Fixed policy fields definitions for mariadb and mysql5. * Replaced deprecated dbt.exceptions.raise_compiler_error() with dbt.exceptions.CompilationError. * Now using dbt.exceptions.DbtDatabaseError insead of dbt.exceptions.DatabaseException. * Update version * Update changelog --------- Co-authored-by: Doug Beatty <[email protected]> * Bump version to 1.5 * Update dbt-core to 1.5 and implement support for model contracts (#163) Update dbt-core to 1.5.9 and implement support for constraints * Update changelog * Fix unit test error - The error was: `AttributeError: 'Namespace' object has no attribute 'MACRO_DEBUGGING'` * Allow Unix socket connection rather than just TCP (#165) * Support Black & MyPy pre-commit hooks (#167) * Add black and mypy as pre-commit hooks * Run black formatter on all files * Add MyPy configuration & make tweaks and ignore errors to make MyPy pass * Add .git-blame-ignore-revs to ignore `black` changes in git blame * Update changelog * Run black formatter on all files * Add black commit to .git-blame-ignore-revs * Run black formatter on all files * Add black commit to .git-blame-ignore-revs * Fix MyPy & black errors * Make the `database` config field nullable again * Fix mypy * Bump version to 1.6 * Bump version to 1.7 * Fix import error --------- Co-authored-by: Luke <[email protected]> Co-authored-by: Doug Beatty <[email protected]>

* Revert "Upgraded to dbt-core 1.4. (#146)" This reverts commit 3db05eb. * Fix version bumping * Migration bump2version (unmaintained) to bump-my-version * Import `bumpversion.cfg` from `dbt-snowflake` * Convert `bumpversion.cfg` to `bumpversion.toml` * Fix a few incorrect version labels * Remove macos and windows as integration targets * Fix requirements conflict between dbt 1.2 and tox * Bump version to 1.3 * Upgraded to dbt-core 1.4. (#146) * Upgraded to dbt-core 1.4. * Updated CHANGELOG. * Fixed policy fields definitions for mariadb and mysql5. * Replaced deprecated dbt.exceptions.raise_compiler_error() with dbt.exceptions.CompilationError. * Now using dbt.exceptions.DbtDatabaseError insead of dbt.exceptions.DatabaseException. * Update version * Update changelog --------- Co-authored-by: Doug Beatty <[email protected]> * Bump version to 1.5 * Update dbt-core to 1.5 and implement support for model contracts (#163) Update dbt-core to 1.5.9 and implement support for constraints * Update changelog * Fix unit test error - The error was: `AttributeError: 'Namespace' object has no attribute 'MACRO_DEBUGGING'` * Allow Unix socket connection rather than just TCP (#165) * Support Black & MyPy pre-commit hooks (#167) * Add black and mypy as pre-commit hooks * Run black formatter on all files * Add MyPy configuration & make tweaks and ignore errors to make MyPy pass * Add .git-blame-ignore-revs to ignore `black` changes in git blame * Update changelog * Run black formatter on all files * Add black commit to .git-blame-ignore-revs * Run black formatter on all files * Add black commit to .git-blame-ignore-revs * Fix MyPy & black errors * Make the `database` config field nullable again * Fix mypy * Bump version to 1.6 * Bump version to 1.7 * Fix import error * Fix unicode decode error (#169) * Update setup.py Explicitly defining utf-8 encoding to avoid UnicodeDecodeError on setup.py in Windows environment * Update CHANGELOG.md --------- Co-authored-by: Scott Gunn <[email protected]> * Pin jsonschema version to fix tests (#174) * Add collation support in profiles.yml / Fix incorrect collation for utf8mb4 (#173) * Add support for charset and collation in profile.yml * Change mysql-connect-python version * Update readme with new profile options * Update setup.py with less restricting mysql-connector-python version after code review Co-authored-by: Matthew Wallace <[email protected]> * Add collation and charset support for mariadb and mysql5 --------- Co-authored-by: Matthew Wallace <[email protected]> * Pin jsonschema version to fix tests * Update black to resolve security alert https://github.com/dbeatty10/dbt-mysql/security/dependabot/5 --------- Co-authored-by: Luke <[email protected]> Co-authored-by: Doug Beatty <[email protected]> Co-authored-by: Scott Gunn <[email protected]> Co-authored-by: Krzysztof Zajączkowski <[email protected]>

lpezet added 2 commits April 21, 2023 23:07

Upgraded to dbt-core 1.4.

908675b

Updated CHANGELOG.

a49f78d

Fixed policy fields definitions for mariadb and mysql5.

8f3b68a

moszutij reviewed Apr 23, 2023

View reviewed changes

lpezet mentioned this pull request Apr 23, 2023

Bug in macro incremental_delete when using composite keys for unique_key #143

Closed

dbeatty10 mentioned this pull request Apr 24, 2023

Test, and hopefully fix, incremental composite keys #144

Merged

3 tasks

Replaced deprecated dbt.exceptions.raise_compiler_error() with dbt.ex…

9472c68

…ceptions.CompilationError.

Now using dbt.exceptions.DbtDatabaseError insead of dbt.exceptions.Da…

21160de

…tabaseException.

Update version

c72400c

dbeatty10 approved these changes Jun 10, 2023

View reviewed changes

Update changelog

47abc17

dbeatty10 merged commit 3db05eb into dbeatty10:main Jun 11, 2023

mwallace582 added a commit that referenced this pull request Jan 9, 2024

Revert "Upgraded to dbt-core 1.4. (#146)"

3de7325

This reverts commit 3db05eb.

lucasfcnunes mentioned this pull request Jan 11, 2024

Is this project dead? #166

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded to dbt-core 1.4. #146

Upgraded to dbt-core 1.4. #146

lpezet commented Apr 21, 2023 •

edited

Loading

lpezet commented Apr 21, 2023 •

edited

Loading

moszutij left a comment

dbeatty10 commented Apr 24, 2023

lpezet commented Apr 24, 2023

BamboOSZ commented Apr 24, 2023

wesen commented May 8, 2023

lpezet commented May 8, 2023

wesen commented May 9, 2023

uraurora commented Jun 10, 2023

dbeatty10 left a comment

lucasfcnunes commented Aug 22, 2023

outinim commented Nov 8, 2023

Upgraded to dbt-core 1.4. #146

Upgraded to dbt-core 1.4. #146

Conversation

lpezet commented Apr 21, 2023 • edited Loading

Description

Checklist

lpezet commented Apr 21, 2023 • edited Loading

moszutij left a comment

Choose a reason for hiding this comment

dbeatty10 commented Apr 24, 2023

lpezet commented Apr 24, 2023

BamboOSZ commented Apr 24, 2023

wesen commented May 8, 2023

lpezet commented May 8, 2023

wesen commented May 9, 2023

uraurora commented Jun 10, 2023

dbeatty10 left a comment

Choose a reason for hiding this comment

lucasfcnunes commented Aug 22, 2023

outinim commented Nov 8, 2023

lpezet commented Apr 21, 2023 •

edited

Loading

lpezet commented Apr 21, 2023 •

edited

Loading