-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAP-498] [Bug] BQ does not retry on 503 #682
Comments
Thanks for reaching out @barberscott ! We'll put this in our queue. The solution might be as simple as adding dbt-bigquery/dbt/adapters/bigquery/connections.py Lines 53 to 59 in 7c21644
|
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers. |
@dbeatty10 Current: Not added ServiceUnavailable on
dbt-bigquery/dbt/adapters/bigquery/connections.py Lines 57 to 63 in 0685167
The ServiceUnavailable class inherits from the ServerError class, so it seems to pass above test. |
Adding it to the But ... the thing that is surprising to me: if Is is possible that the BigQuery client is raising a different error class for 503 errors other than @jx2lee Do you happen to have any python stacktraces available where you ran into this problem and dbt-bigquery didn't retry? |
no, i expected
That issue has never been occured...🙃 IMO, If the issue reporter can't provide more error logs, I think okay to close the issue.
|
@dbeatty10 |
We did hit this recently. We use external-tables on a
Because this happens intermittently on an isolated system, I don't have more logs. |
Thanks for this report @rrbarbosa ! Since this is intermittent (and maybe relatively rare also), it has been hard to nail down. If anyone can provide information to suggest that dbt is not retrying at least once, that would be very helpful 🙏 |
@jx2lee -- would you be willing to raise a PR with the addition you made to this test case? I think that would be sufficient for us to establish that the |
@dbeatty10 okay, i would create PR included above test code soon! |
@dbeatty10 |
I'm not sure if this is the same code path, but we are seeing a problem with Dataproc (Python models) that dbt is submitting, where dbt successfully submits the batch job, then, during the polling in
We have seen the issue twice in a week, and running dbt-bigquery 1.8.1 |
Got hit by this issue today, while generating "seed" tables with DBT running in CloudBuild:
We're using impersonation with |
GH closed this because an attached PR was merged. I think there is more to this, so I'm leaving it open. |
Is this a new bug in dbt-bigquery?
Current Behavior
Current if BigQuery returns a 503 error we do not retry even though BigQuery recommends that as the course of action.
Expected Behavior
This is not a regression but rather an oversight -- 503 errors should be both retryable and reopenable since it indicates a transient unavailable condition in BigQuery
Steps To Reproduce
Transient -- requires intermittent error from BQ.
Relevant log output
No response
Environment
Additional Context
No response
The text was updated successfully, but these errors were encountered: