Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf >=5.0,<=6.0 #10969

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Use protobuf >=5.0,<=6.0 #10969

merged 12 commits into from
Nov 19, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 4, 2024

Resolves #10658

Problem

Need to upgrade protobuf. It's gotten harder to install the older versions we've been using.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner November 4, 2024 15:57
@cla-bot cla-bot bot added the cla:yes label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank closed this Nov 4, 2024
@gshank gshank reopened this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (2a75dd4) to head (6895c82).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10969      +/-   ##
==========================================
- Coverage   89.13%   89.11%   -0.02%     
==========================================
  Files         183      183              
  Lines       23644    23646       +2     
==========================================
- Hits        21074    21072       -2     
- Misses       2570     2574       +4     
Flag Coverage Δ
integration 86.51% <27.27%> (-0.02%) ⬇️
unit 62.77% <27.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.77% <27.27%> (+<0.01%) ⬆️
Integration Tests 86.51% <27.27%> (-0.02%) ⬇️
---- 🚨 Try these New Features:

@gshank gshank closed this Nov 12, 2024
@gshank gshank reopened this Nov 12, 2024
@gshank gshank closed this Nov 13, 2024
@gshank gshank reopened this Nov 13, 2024
dev-requirements.txt Outdated Show resolved Hide resolved
@gshank gshank merged commit f080346 into main Nov 19, 2024
54 of 56 checks passed
@gshank gshank deleted the upgrade_protobuf branch November 19, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tech Debt] Bump protoc to v27 or v28
2 participants