Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf >=5.0,<=6.0 #10969

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Use protobuf >=5.0,<=6.0 #10969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
afbc7e4
Use protobuf >=5.0,<=6.0
gshank Nov 4, 2024
3f02208
Changie
gshank Nov 4, 2024
52a9441
missing comma
gshank Nov 4, 2024
d384901
Use dbt-adapters branch with protobuf version changed
gshank Nov 4, 2024
446c93f
Rename dbt-common branch
gshank Nov 12, 2024
c2301cd
Merge branch 'main' into upgrade_protobuf
gshank Nov 12, 2024
d3afd2d
Update generation version of core_types_pb2.py
gshank Nov 12, 2024
3478acc
Bump dbt-common version to 1.13
gshank Nov 12, 2024
7172be3
Merge branch 'main' into upgrade_protobuf
gshank Nov 19, 2024
5f253cc
Update dev-requirements.txt
gshank Nov 19, 2024
442ce72
Try specifying protobuf in dev-requirements.txt
gshank Nov 19, 2024
6895c82
Execute dev_req again
gshank Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20241104-110509.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: Upgrade protobuf
time: 2024-11-04T11:05:09.433244-05:00
custom:
Author: gshank
Issue: "10658"
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
python -m pip install --user --upgrade pip
python -m pip --version
make dev
make dev_req
mypy --version
dbt --version

Expand Down
29 changes: 20 additions & 9 deletions core/dbt/events/core_types_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
# with major versions in each new minor version of dbt-core.
"click>=8.0.2,<9.0",
"networkx>=2.3,<4.0",
"protobuf>=4.0.0,<5",
"protobuf>=5.0,<6.0",
"requests<3.0.0", # should match dbt-common
"snowplow-tracker>=1.0.2,<2.0",
# ----
Expand All @@ -71,7 +71,7 @@
"dbt-extractor>=0.5.0,<=0.6",
"dbt-semantic-interfaces>=0.7.4,<0.8",
# Minor versions for these are expected to be backwards-compatible
"dbt-common>=1.11.0,<2.0",
"dbt-common>=1.13.0,<2.0",
"dbt-adapters>=1.9.0,<2.0",
# ----
# Expect compatibility with all new versions of these packages, so lower bounds only.
Expand Down
3 changes: 2 additions & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ isort==5.13.2
mypy==1.4.1
pip-tools
pre-commit
protobuf>=5.0,<6.0
pytest>=7.4,<8.0
pytest-cov
pytest-csv>=3.0,<4.0
Expand All @@ -32,7 +33,7 @@ types-docutils
types-PyYAML
types-Jinja2
types-mock
types-protobuf>=4.0.0,<5.0.0
types-protobuf>=5.0,<6.0
types-pytz
types-requests
types-setuptools
Expand Down