Fix bugs in dimension lookup #1474
Draft
+285
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…granularity And a lot of downstream changes as a result. Previously, we were getting a time dimension's defined granularity from just its element_name. This is not sufficient information, since there might be multiple dimensions with the same name across semantic models, all with potentially different granularities. This updates those methods to take in a SemanticModelElementReference, which contains both the time dimension's element_name and its semantic model name. This caused a lot of downsream impact, since we needed to get the semantic model context wherever those methods were called. I also did some type cleanup along the way to try to simplify the code with this change in mind.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.