Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in dimension lookup #1474

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    b1c9aba View commit details
    Browse the repository at this point in the history
  2. Require semantic_model context when getting time dimension's defined …

    …granularity
    
    And a lot of downstream changes as a result. Previously, we were getting a time dimension's defined granularity from just its element_name. This is not sufficient information, since there might be multiple dimensions with the same name across semantic models, all with potentially different granularities. This updates those methods to take in a SemanticModelElementReference, which contains both the time dimension's element_name and its semantic model name. This caused a lot of downsream impact, since we needed to get the semantic model context wherever those methods were called. I also did some type cleanup along the way to try to simplify the code with this change in mind.
    courtneyholcomb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4bdd2fa View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. WIP wut.

    courtneyholcomb committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8bb2430 View commit details
    Browse the repository at this point in the history