DT-1316, DT-1328 and DT-1273 changes #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt-gt
reviewed
Jul 31, 2024
Comment on lines
57
to
67
| "address": { | ||
| "name": "Port of Rotterdam", | ||
| "street": "Europoort Rotterdam", | ||
| "postCode": "3198 LK", | ||
| "city": "Rotterdam", | ||
| "countryCode": "NL" | ||
| }, | ||
| "geoCoordinate": { | ||
| "latitude": "53.551086", | ||
| "longitude": "9.993682" | ||
| } |
There was a problem hiding this comment.
If we have this data, it should be a placeholder otherwise it will not match the UNLocationCode.
I recommend we do not have it for exactly that reason.
There was a problem hiding this comment.
Note: It is fine for the "all attributes" message but not for the base API message used in all other tests (Given it was called -regular I assumed it was for the regular tests)
There was a problem hiding this comment.
I think it doesnt make sense to add all addresses, as they must point exactly to the same location. I will remove them
nt-gt
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.