Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1316, DT-1328 and DT-1273 changes #105

Merged
merged 4 commits into from
Aug 5, 2024
Merged

DT-1316, DT-1328 and DT-1273 changes #105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b62054
DT-1316, DT-1328 and DT-1273 changes
preetamnpr Jul 11, 2024
3df4657
merged changes
preetamnpr Jul 17, 2024
c12e07b
DT-1316 removed redundant address pointers
preetamnpr Aug 2, 2024
6641121
DT-1316 merged dev
preetamnpr Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions booking/src/main/resources/standards/booking/messages/booking-api-2.0.0-regular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,35 @@
"shipmentLocations": [
{
"location": {
"locationType": "UNLO",
"UNLocationCode": "POL_UNLOCATION_CODE_PLACEHOLDER"
"UNLocationCode": "POL_UNLOCATION_CODE_PLACEHOLDER",
"address": {
"name": "Port of Rotterdam",
"street": "Europoort Rotterdam",
"postCode": "3198 LK",
"city": "Rotterdam",
"countryCode": "NL"
},
"geoCoordinate": {
"latitude": "53.551086",
"longitude": "9.993682"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have this data, it should be a placeholder otherwise it will not match the UNLocationCode.

I recommend we do not have it for exactly that reason.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It is fine for the "all attributes" message but not for the base API message used in all other tests (Given it was called -regular I assumed it was for the regular tests)

Copy link
Contributor Author

@preetamnpr preetamnpr Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesnt make sense to add all addresses, as they must point exactly to the same location. I will remove them

},
"locationTypeCode": "POL"
},
{
"location": {
"locationType": "UNLO",
"UNLocationCode": "POD_UNLOCATION_CODE_PLACEHOLDER"
"UNLocationCode": "POD_UNLOCATION_CODE_PLACEHOLDER",
"address": {
"name": "Port of Hamburg",
"street": " Neuer Wandrahm 4",
"postCode": "20457",
"city": "Hamburg",
"countryCode": "DE"
},
"geoCoordinate": {
"latitude": "51.907619",
"longitude": "4.547350"
}
},
"locationTypeCode": "POD"
}
Expand Down
Loading
Loading