Pin packages #219
Merged
Pin packages #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
force-pushed
the
pin-packages
branch
28 times, most recently
from
6da62d2
to
5d46846
Compare
The previous version of Debcrafter didn't catch these mistakes. Now they were discovered and fixed.
Verifying signatures is not that great because when the keys expire the build is broken. We instead pin the packages while still being able to verify when the pin is updated. This already has some keys expired so the pins are added here.
The tests were previously running even when build failed which was useless and wasteful. This switches it to run only on success.
Kixunil
force-pushed
the
pin-packages
branch
from
5d46846
to
360f42f
Compare
CI was building packages one after another in a single VM. This is slow, has the risk of one package affecting another and makes it harder to figure out which job failed. This change adds a preparation job which builds the image and gets the list of packages and changes build job into matrix depending on the prepare job.
When a service fails to start the maintainerscript would only print a help, not full log. This is annoying when testing in CI as there's no way to do that and even in case of local tests it's just one more step. This change adds a check that would print the log for service packages. Although it won't show anything if the failure happened before starting, this is OK, it's just debug info.
Kixunil
force-pushed
the
pin-packages
branch
4 times, most recently
from
66b9552
to
4d2cc76
Compare
Previously imported files had to specified twice - in `build_rules` and in `sps` files. This uses the new debcrafter feature to avoid it and prepares for heavier CI caching.
`lnd-genmacaroon` doesn't use these, it's probably some copy-paste mistake.
Kixunil
force-pushed
the
pin-packages
branch
2 times, most recently
from
25636dc
to
c3ddace
Compare
Previously caching was only implemented for container image building but not for packages which still took a huge time to rebuild. This implements caching so that packages that didn't change aren't rebuilt.
|
Screw it, it works in every other testing environment. Probably something to do with containers... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying signatures is not that great because when the keys expire the build is broken. We instead pin the packages while still being able to verify when the pin is updated. This already has some keys expired so the pins are added here.