-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin packages #219
Merged
Merged
Pin packages #219
Commits on Dec 19, 2023
-
The previous version of Debcrafter didn't catch these mistakes. Now they were discovered and fixed.
Configuration menu - View commit details
-
Copy full SHA for 73e49d7 - Browse repository at this point
Copy the full SHA 73e49d7View commit details -
Verifying signatures is not that great because when the keys expire the build is broken. We instead pin the packages while still being able to verify when the pin is updated. This already has some keys expired so the pins are added here.
Configuration menu - View commit details
-
Copy full SHA for c8d2d27 - Browse repository at this point
Copy the full SHA c8d2d27View commit details -
Run tests only if the jobs succeeded.
The tests were previously running even when build failed which was useless and wasteful. This switches it to run only on success.
Configuration menu - View commit details
-
Copy full SHA for 4d28028 - Browse repository at this point
Copy the full SHA 4d28028View commit details
Commits on Jan 3, 2024
-
CI was building packages one after another in a single VM. This is slow, has the risk of one package affecting another and makes it harder to figure out which job failed. This change adds a preparation job which builds the image and gets the list of packages and changes build job into matrix depending on the prepare job.
Configuration menu - View commit details
-
Copy full SHA for 6f6c9ab - Browse repository at this point
Copy the full SHA 6f6c9abView commit details -
Print journal of service if installation fails
When a service fails to start the maintainerscript would only print a help, not full log. This is annoying when testing in CI as there's no way to do that and even in case of local tests it's just one more step. This change adds a check that would print the log for service packages. Although it won't show anything if the failure happened before starting, this is OK, it's just debug info.
Configuration menu - View commit details
-
Copy full SHA for abb4eb7 - Browse repository at this point
Copy the full SHA abb4eb7View commit details -
Use
import_files
feature of new debcrafterPreviously imported files had to specified twice - in `build_rules` and in `sps` files. This uses the new debcrafter feature to avoid it and prepares for heavier CI caching.
Configuration menu - View commit details
-
Copy full SHA for 768cd73 - Browse repository at this point
Copy the full SHA 768cd73View commit details -
Remove useless dependencies from
lnd-genmacaroon
`lnd-genmacaroon` doesn't use these, it's probably some copy-paste mistake.
Configuration menu - View commit details
-
Copy full SHA for 561fc23 - Browse repository at this point
Copy the full SHA 561fc23View commit details -
Previously caching was only implemented for container image building but not for packages which still took a huge time to rebuild. This implements caching so that packages that didn't change aren't rebuilt.
Configuration menu - View commit details
-
Copy full SHA for 052fe86 - Browse repository at this point
Copy the full SHA 052fe86View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.