fix: checks address proposer #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xShaito
requested changes
Jul 9, 2024
| @@ -70,6 +70,7 @@ contract BondedDisputeModule is Module, IBondedDisputeModule { | |||
| _amount: _params.bondSize | |||
| }); | |||
| } else if (_status == IOracle.DisputeStatus.Won) { | |||
| if (_dispute.proposer != _response.proposer) revert BondedDisputeModule_OnlyResponseProposer(); | |||
There was a problem hiding this comment.
I would call it BondedDisputeModule_SelfDispute().
Also add tests for this case
There was a problem hiding this comment.
I don't see why call it self because this happens when you try to change the address it receives but oka.
There was a problem hiding this comment.
Indeed, what matters is that the proposer in the IOracle.Response struct is expected to be equal to the same in the IOracle.Dispute struct, despite being arbitrarily inputted by the caller. The fact that someone might dispute himself is not the focus of the issue and apparently is not affected by the reversion above.
… fix/disputer-address
…phet-modules into fix/disputer-address
I agree @0xJabberwock. I prefer if we do it in the oracle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-12