Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checks address proposer #49

Closed
wants to merge 5 commits into from
Closed

fix: checks address proposer #49

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5b3e20
fix: checks address proposer
ashitakah Jul 9, 2024
36b0bb6
Merge branch 'dev' into fix/disputer-address
0xShaito Jul 9, 2024
4e4beba
fix: comments
ashitakah Jul 11, 2024
ecc1680
Merge branch 'dev' of github.com:defi-wonderland/prophet-modules into…
ashitakah Jul 11, 2024
a07a7cd
Merge branch 'fix/disputer-address' of github.com:defi-wonderland/pro…
ashitakah Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion solidity/contracts/modules/dispute/BondedDisputeModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ contract BondedDisputeModule is Module, IBondedDisputeModule {
function onDisputeStatusChange(
bytes32 _disputeId,
IOracle.Request calldata _request,
IOracle.Response calldata, /* _response */
IOracle.Response calldata _response, /* _response */
IOracle.Dispute calldata _dispute
) external onlyOracle {
RequestParameters memory _params = decodeRequestData(_request.disputeModuleData);
Expand All @@ -70,6 +70,7 @@ contract BondedDisputeModule is Module, IBondedDisputeModule {
_amount: _params.bondSize
});
} else if (_status == IOracle.DisputeStatus.Won) {
if (_dispute.proposer != _response.proposer) revert BondedDisputeModule_OnlyResponseProposer();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it BondedDisputeModule_SelfDispute().

Also add tests for this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why call it self because this happens when you try to change the address it receives but oka.

Copy link
Member

@0xJabberwock 0xJabberwock Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, what matters is that the proposer in the IOracle.Response struct is expected to be equal to the same in the IOracle.Dispute struct, despite being arbitrarily inputted by the caller. The fact that someone might dispute himself is not the focus of the issue and apparently is not affected by the reversion above.

// Disputer won, we pay the disputer and release their bond
_params.accountingExtension.pay({
_requestId: _dispute.requestId,
Expand Down
8 changes: 8 additions & 0 deletions solidity/interfaces/modules/dispute/IBondedDisputeModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ import {IAccountingExtension} from '../../extensions/IAccountingExtension.sol';
* the tokens are either returned to the disputer or to the proposer.
*/
interface IBondedDisputeModule is IDisputeModule {
/*///////////////////////////////////////////////////////////////
ERRORS
//////////////////////////////////////////////////////////////*/

/**
* @notice Thrown when the response proposer tries to dispute the response
*/
error BondedDisputeModule_OnlyResponseProposer();
/*///////////////////////////////////////////////////////////////
STRUCTS
//////////////////////////////////////////////////////////////*/
Expand Down
Loading