don't use std abs_diff, put it in test_utils instead, run tests with msrv in action #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklan
changed the title
zachschuermann
approved these changes
Dec 13, 2024
nicklan
changed the title
rtyler
approved these changes
Dec 13, 2024
OussamaSaoudi-db
approved these changes
Dec 13, 2024
scovich
reviewed
Dec 13, 2024
| @@ -106,3 +106,13 @@ pub fn into_record_batch(engine_data: Box<dyn EngineData>) -> RecordBatch { | |||
| .unwrap() | |||
| .into() | |||
| } | |||
|
|
|||
| /// We implement abs_diff here so we don't have to bump our msrv. | |||
| /// TODO: Remove and use std version when msrv >= 1.81.0 | |||
There was a problem hiding this comment.
Do we have a tracking issue for this so we don't forget?
(really it would be neat if rust had a way to annotate these sorts of workarounds, so they start failing once MSRV bumps)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this change tested?