Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve AWS credential loading between S3 and DynamoDb code paths #2887

Merged
merged 4 commits into from
Sep 17, 2024

Merge branch 'main' into bug/iam-assume-role

9846bac
Select commit
Loading
Failed to load commit list.
Merged

feat: improve AWS credential loading between S3 and DynamoDb code paths #2887

Merge branch 'main' into bug/iam-assume-role
9846bac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2024 in 0s

72.42% (-0.20%) compared to 546a344

View this Pull Request on Codecov

72.42% (-0.20%) compared to 546a344

Details

Codecov Report

Attention: Patch coverage is 74.48276% with 74 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (546a344) to head (9846bac).

Files with missing lines Patch % Lines
crates/aws/src/credentials.rs 72.72% 28 Missing and 14 partials ⚠️
crates/aws/src/storage.rs 76.47% 31 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2887      +/-   ##
==========================================
- Coverage   72.61%   72.42%   -0.20%     
==========================================
  Files         131      131              
  Lines       40016    40011       -5     
  Branches    40016    40011       -5     
==========================================
- Hits        29057    28976      -81     
- Misses       9088     9166      +78     
+ Partials     1871     1869       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.