Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ListingSchemaProvider not forwarding custom storage_options #2924

Merged
merged 2 commits into from
Oct 7, 2024

test: added two azure integration tests to check if storage_options g…

67ba44b
Select commit
Loading
Failed to load commit list.
Merged

fix: ListingSchemaProvider not forwarding custom storage_options #2924

test: added two azure integration tests to check if storage_options g…
67ba44b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 1s

72.41% (+0.00%) compared to 8701046

View this Pull Request on Codecov

72.41% (+0.00%) compared to 8701046

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (8701046) to head (67ba44b).

Files with missing lines Patch % Lines
crates/core/src/data_catalog/storage/mod.rs 50.00% 0 Missing and 1 partial ⚠️
crates/core/src/storage/mod.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2924   +/-   ##
=======================================
  Coverage   72.40%   72.41%           
=======================================
  Files         131      131           
  Lines       40496    40496           
  Branches    40496    40496           
=======================================
+ Hits        29323    29325    +2     
+ Misses       9292     9291    -1     
+ Partials     1881     1880    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov