[Kernel][Metrics][PR#3] Metrics report JSON serializer and LoggingMetricsReporter for the default engine #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonport-db
force-pushed
the
metrics-3
branch
2 times, most recently
from
6966594 to
632985b
Compare
allisonport-db
changed the title
5 tasks
allisonport-db
force-pushed
the
metrics-3
branch
from
d8c08dd to
fea8cd0
Compare
scottsand-db
requested changes
Dec 4, 2024
...el/kernel-defaults/src/main/java/io/delta/kernel/defaults/engine/LoggingMetricsReporter.java
Outdated
Show resolved
Hide resolved
...el/kernel-defaults/src/main/java/io/delta/kernel/defaults/engine/LoggingMetricsReporter.java
Outdated
Show resolved
Hide resolved
allisonport-db
force-pushed
the
metrics-3
branch
from
fea8cd0 to
7a54a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is based off of #3903
See the diff for just this PR here
Adds a JSON serializer for metrics reports with serialization logic for SnapshotReport. Also adds a
LoggingMetricsReporterto the default implementation which simply logs the JSON serialized reports using Log4J.How was this patch tested?
Adds a test suite.
Does this PR introduce any user-facing changes?
No.