Proofpoint Isolation Event Collector #38101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noydavidi
changed the title
Coverage Report
|
||||||||||||||||||||||||||||||
remote changes for last-run
...olation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.yml
Outdated
Show resolved
Hide resolved
...olation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.yml
Outdated
Show resolved
Hide resolved
...olation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.yml
Outdated
Show resolved
Hide resolved
...egrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector_description.md
Outdated
Show resolved
Hide resolved
Packs/ProofpointIsolation/Integrations/ProofpointIsolationEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/ProofpointIsolation/Integrations/ProofpointIsolationEventCollector/README.md
Outdated
Show resolved
Hide resolved
...egrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector_description.md
Outdated
Show resolved
Hide resolved
Packs/ProofpointIsolation/Integrations/ProofpointIsolationEventCollector/README.md
Outdated
Show resolved
Hide resolved
|
@Shellyber Doc review completed. |
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Shellyber
requested changes
Jan 15, 2025
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
...olation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.yml
Outdated
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
Comment on lines
196
to
199
| except DemistoException as e: | ||
| if 'Forbidden' in str(e) or 'Authorization' in str(e): | ||
| message = 'Authorization Error: make sure API Key is correctly set' | ||
| else: |
There was a problem hiding this comment.
Are you sure you need this part?
There was a problem hiding this comment.
We want the test-module to fall when the api key is incorrect, no?
There was a problem hiding this comment.
yeah, the question is if we need it. Last time, we saw that the API returned the error and did not reach this part at all (a former integration we worked on). When you're testing this, do you get to this part?
There was a problem hiding this comment.
It got to the "if" part but its not necessary i think? This is the error as is (without the if), it is informative.
Shellyber
reviewed
Jan 20, 2025
...lation/Integrations/ProofpointIsolationEventCollector/test_data/get_events_raw_response.json
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Outdated
Show resolved
Hide resolved
...solation/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector.py
Show resolved
Hide resolved
...ion/Integrations/ProofpointIsolationEventCollector/ProofpointIsolationEventCollector_test.py
Outdated
Show resolved
Hide resolved
|
@Shellyber Reviewed doc again. Looks good. |
Shellyber
reviewed
Jan 22, 2025
...egrations/ProofpointIsolationEventCollector/test_data/get_events_same_time_raw_response.json
Outdated
Show resolved
Hide resolved
Shellyber
reviewed
Jan 22, 2025
...solation/Integrations/ProofpointIsolationEventCollector/test_data/get_events_first_time.json
Outdated
Show resolved
Hide resolved
Shellyber
approved these changes
Jan 26, 2025
sdaniel6
pushed a commit
that referenced
this pull request
Jan 27, 2025
Created a new pack and a new event collector - proofpoint isolation
OneToughMonkey
pushed a commit
to OneToughMonkey/demisto-content
that referenced
this pull request
Jan 27, 2025
Created a new pack and a new event collector - proofpoint isolation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
A new Event Collector for Proofpoint Isolation.
Must have