Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proofpoint Isolation Event Collector #38101
Proofpoint Isolation Event Collector #38101
Changes from 17 commits
a7abda5
5eeb155
e005a10
500ceb9
8f1df80
27552a1
78f02fd
27354e7
c181cd6
f49e108
3a1f417
799ae7a
9117b57
24df0db
c416e2d
236af95
35656d7
beb20e2
4c6d69d
76e88a1
275831b
63e6249
856384b
49f91d4
aafb2ec
0a09ee0
95ace78
edce68b
447af5c
74ebacf
cf446cd
66d1a5c
aa2f64e
e44823f
3c37b8e
18a1d7b
b0bc75c
39fb580
3fa1376
8da139c
0513fad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you need this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want the test-module to fall when the api key is incorrect, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the question is if we need it. Last time, we saw that the API returned the error and did not reach this part at all (a former integration we worked on). When you're testing this, do you get to this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It got to the "if" part but its not necessary i think? This is the error as is (without the if), it is informative.
![image](https://private-user-images.githubusercontent.com/77931201/404785910-3c818230-cd68-4127-8b91-7e8896cdee36.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDM5NjIsIm5iZiI6MTczOTIwMzY2MiwicGF0aCI6Ii83NzkzMTIwMS80MDQ3ODU5MTAtM2M4MTgyMzAtY2Q2OC00MTI3LThiOTEtN2U4ODk2Y2RlZTM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE2MDc0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJlM2JiZTkzNDkxYmZkYWM1Mjc1NTgxNzA3N2I4Mzk5YmI2NzlhODU4OTZjNDEwNzk3YWRjOTk0OTM4NzAzNTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-iLZBEoeowwyk8ITKljUlXwBXYuojxUQB1MGNGUfP4Q)