fix: improve lockfile v4 and use deno_semver to fix duplicate entry issue #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 27, 2024
Comment on lines
-166
to
-167
| "jsr:@std/[email protected]": "jsr:@std/[email protected]", | ||
| "jsr:@std/assert@^0.210.0": "jsr:@std/[email protected]", |
There was a problem hiding this comment.
You'll notice here that we got smarter and can tell these are actually the same version requirement now.
bartlomieju
approved these changes
Aug 27, 2024
| #[serde(skip_serializing_if = "BTreeSet::is_empty")] | ||
| #[serde(default)] | ||
| pub dependencies: BTreeSet<String>, | ||
| pub dependencies: HashSet<JsrDepPackageReq>, |
There was a problem hiding this comment.
No longer need to keep ordering?
There was a problem hiding this comment.
It's handled in the printer only now.
|
I'm going to merge this one, but will follow up with a new PR that normalizes the versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue found here: denoland/deno_graph#517 (comment)
Also, makes the "specifiers" area less verbose for lockfile v4.