Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for case-insensitive matches #34

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jul 19, 2022

Implements whatwg/urlpattern#168
Closes #12

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the case flag an options bag

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate_matcher is going to significantly suffer here. It will be unable to generate matchers for case insensitive parts

@crowlKats
Copy link
Member Author

generate_matcher is going to significantly suffer here. It will be unable to generate matchers for case insensitive parts

thats a problem, but i dont think there is much we can do (I'd be happily proven wrong)

@vazexqi
Copy link

vazexqi commented Feb 28, 2023

@crowlKats @lucacasonato - Any chance that this might land in Deno? According to https://developer.mozilla.org/en-US/docs/Web/API/URLPattern#browser_compatibility Deno has everything else implemented according to the spec except for the ignoreCase feature.

src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 0594545 into denoland:main Jul 31, 2024
2 checks passed
@crowlKats crowlKats deleted the 168 branch July 31, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix URLPatternResult#inputs behaviour
3 participants