feat: add ga4 plugin #654
Merged
feat: add ga4 plugin #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
suggested changes
Jan 15, 2024
Co-authored-by: Asher Gomez <[email protected]>
Co-authored-by: Asher Gomez <[email protected]>
|
@iuioiua, is this ready now? |
iuioiua
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't want to block you anymore, so I've created the PR as is. Although I did just recently make a change to no longer hardcode the fresh version in my plugin, and it no longer references ga4 main. (In the unlikely event that anyone updates the project, we're now safe.)
I will try to finish the tests later this week, and then I think it's time for a
0.1.0release, since I suppose not a lot will change after the tests are done.