init version #3
Merged
init version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojtaba-deriv
approved these changes
Jun 26, 2024
raju-deriv
reviewed
Jun 26, 2024
mukesh-deriv
approved these changes
Jun 27, 2024
nihal-deriv
reviewed
Jun 27, 2024
nihal-deriv
reviewed
Jun 27, 2024
nihal-deriv
reviewed
Jun 27, 2024
nihal-deriv
reviewed
Jun 27, 2024
nihal-deriv
reviewed
Jun 27, 2024
nihal-deriv
reviewed
Jun 27, 2024
chylli-deriv
commented
Jun 28, 2024
nihal-deriv
reviewed
Jun 28, 2024
nihal-deriv
reviewed
Jul 1, 2024
nihal-deriv
reviewed
Jul 1, 2024
nihal-deriv
reviewed
Jul 1, 2024
| field $client_key :param; | ||
| field $features :param //= {}; | ||
| field $cache_ttl :param //= 60; | ||
| field $cache //= WebService::GrowthBook::InMemoryFeatureCache->singleton; |
There was a problem hiding this comment.
do we need this cache object here ? From my understanding The FeatureRepository seems to be abstracting the cache from the the Growthbook class Object ?
There was a problem hiding this comment.
This parameter is used to set cache module in FeatureRepository. Without this one we cannot custom cache object in FeatureRepository.
nihal-deriv
approved these changes
Jul 2, 2024
- Initial release - load features - get feature value - is_on - is_off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are looking at creating simple SDK for Growthbook (Feature Flags). We have written simple code to access flags but it will be great to get separate modules which can be used by multiple teams. here is the code we have