-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates and bug fixes ahead of next version of VACs #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a mix of changes and updates under the umbrella of prepping for the next version of VACs. (I was hoping to include some additional documentation and unit tests but I will do that in a separate PR.)
Key updates include:
subprocess
and usingmultiprocessing.set_start_method('spawn')
.fastspecfit-qa
has been renamedfastqa
and the QA code has been ported to a new module,fastspecfit.qa
.FLYA_1215_CONT
,LOGL_1450
,LOGL_1700
, andLOGL_3000
have been added to the data model (see Wish list of outputs for a QSO VAC #112).{LINENAME}_BOXFLUX_IVAR
and{LINENAME}_FLUX_IVAR
have been updated / corrected, following the analysis in Equivalent width uncertainties are significantly lower in v2 #127 (comment).