Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Default Prefix to New Fee Estimation Constant Names #1256

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Add Default Prefix to New Fee Estimation Constant Names #1256

merged 3 commits into from
Apr 23, 2024

Conversation

tholonious
Copy link
Contributor

No description provided.

This was referenced Apr 22, 2024
Merged
Merged
@tholonious Graphite App
Copy link
Contributor Author

tholonious commented Apr 22, 2024 •
edited by lazynina
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tholonious and the rest of your teammates on Graphite Graphite

@tholonious tholonious mentioned this pull request Apr 22, 2024
Draft
Base automatically changed from diamondhands/KILL-LAST-MEMPOOL-FEE-ESTIMATION-BUGS to feature/proof-of-stake April 22, 2024 18:41
@tholonious tholonious force-pushed the Add_Default_Prefix_to_New_Fee_Estimation_Constant_Names branch from 79547eb to 48a4c4d Compare April 22, 2024 18:45
@tholonious tholonious mentioned this pull request Apr 22, 2024
Merged
@tholonious tholonious marked this pull request as ready for review April 22, 2024 20:44
@tholonious tholonious requested a review from a team as a code owner April 22, 2024 20:44
@tholonious tholonious force-pushed the Add_Default_Prefix_to_New_Fee_Estimation_Constant_Names branch from b570586 to 3f2401d Compare April 22, 2024 21:02
This was referenced Apr 22, 2024
Merged
Merged
lazynina
lazynina approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@lazynina lazynina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit in the comments, but otherwise LGTM.

lib/constants.go Show resolved Hide resolved
@lazynina lazynina mentioned this pull request Apr 23, 2024
Merged
@tholonious Graphite App
Copy link
Contributor Author

tholonious commented Apr 23, 2024 •
edited
Loading

Merge activity

@tholonious tholonious merged commit 8045c90 into feature/proof-of-stake Apr 23, 2024
6 checks passed
@tholonious tholonious deleted the Add_Default_Prefix_to_New_Fee_Estimation_Constant_Names branch April 23, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazynina lazynina lazynina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tholonious @lazynina