Use Global Params For Fee Estimator Congestion and Priority Params #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @tholonious and the rest of your teammates on |
lazynina
approved these changes
Apr 23, 2024
| bc.params.DefaultMempoolPastBlocksCongestionFactorBasisPoints, | ||
| bc.params.DefaultMempoolPastBlocksPriorityPercentileBasisPoints, | ||
| maxBlockSizeBytes) | ||
| newFeeEstimate, err := mempool.EstimateFee(atomicTxn, 0, maxBlockSizeBytes) |
There was a problem hiding this comment.
Should we pass in MinFeeRateNanosPerKB here instead of 0? I think I missed this call site in my earlier PR.
Merge activity
|
tholonious
force-pushed
the
Create_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params
branch
from
6bd1a19
to
03f90a4
Compare
Base automatically changed from
Create_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params
to
feature/proof-of-stake
April 23, 2024 02:41
tholonious
force-pushed
the
Use_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params
branch
from
465a25d
to
89fc9ca
Compare
tholonious
deleted the
Use_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Global Params For Fee Estimator Congestion and Priority Params
Revert minFeeRate usage in inner atomic txn transaction