-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/kv + routes #23
Feat/kv + routes #23
Conversation
ping @sameo for a review |
@charley04310 Any idea why the CI is not triggered with that PR? |
@sameo, I would say that this mainly comes from the fact that the CI is only implemented on push event. Would the workflow need updating like something like this ?
|
Ah yes, it should. Thanks! |
All PRs should trigger the CI. |
Please rebase this PR. |
Signed-off-by: Charley <[email protected]>
Signed-off-by: Mauran <[email protected]>
Should be good now |
ed1e9bc
to
62f28f0
Compare
…very 5 sec Signed-off-by: Mauran <[email protected]>
…ashmap Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
Signed-off-by: Charley <[email protected]> Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
…re update, fix formatting Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
Signed-off-by: Mauran <[email protected]>
ping @sameo for a review |
this pr has been coded by @sea-gull-diana here
What's this PR do ?
This PR takes the
kv
implementation from @charley04310 's PR and uses it to implement routesworkloads
andinstances
When scheduling an instance in the
POST instances
route, the program creates a thread where it follows the stream returned by the scheduler and saves updates to akv::Batch
, which is read and saved to the kv store every 5 seconds.We are also now generating uuids for instances and send them to scheduler on instance creation. These uuids can be sent to scheduler later in order to stop or destroy instances.
Other changes:
KeyValueBatch
struct which has abatch
property and implementsDefer
andDerefMut
(hopefully correctly), thus allowing me to clear the batch after every update.