chore(sns): Duplicate ClaimSwapNeuronsRequest into Swap, so the version in SNS Governance can be changed independently #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
from
ecc727b to
683c174
Compare
aterga
reviewed
Sep 3, 2024
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
from
b1d3dfc to
9670985
Compare
anchpop
changed the title
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
5 times, most recently
from
f3085ca to
7955941
Compare
… Governance can be changed independently
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
from
7955941 to
a217819
Compare
max-dfinity
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to remove the
NeuronParametersfield from Governance. This extra rigamarole is required because the field is not optional, so we need to make sure the callee is not expecting it before the caller stops providing it in the request.Once #1297 is released, this PR should be reverted. With that in mind, I've implemented it optimizing for revert-ability. This means avoiding doing refactors that would potentially be painful to revert, if the code continued to change between now and then.
Next PR →