chore(sns): Remove neuron_parameters from ClaimSwapNeuronsRequest on SNS Governance's side #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
changed the title
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
from
ecc727b to
56ee9ca
Compare
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
from
b1d3dfc to
9670985
Compare
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
3 times, most recently
from
e14d74c to
b54ddd7
Compare
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
from
4b84e61 to
e5ded0d
Compare
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
2 times, most recently
from
dbe6f88 to
b54cac9
Compare
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
from
e5ded0d to
42ca540
Compare
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
from
b54cac9 to
cb478c2
Compare
anchpop
force-pushed
the
@anchpop/claim-swap-neurons-request-duplication
branch
3 times, most recently
from
7955941 to
a217819
Compare
max-dfinity
approved these changes
Sep 4, 2024
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
from
cb478c2 to
a82c5a7
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…on in SNS Governance can be changed independently (#1295) This will allow us to remove the `NeuronParameters` field from Governance. This extra rigamarole is required because the field is not optional, so we need to make sure the callee is not expecting it before the caller stops providing it in the request. Once #1297 is released, this PR should be reverted. With that in mind, I've implemented it optimizing for revert-ability. This means avoiding doing refactors that would potentially be painful to revert, if the code continued to change between now and then. [Next PR →](#1297)
Base automatically changed from
@anchpop/claim-swap-neurons-request-duplication
to
master
September 4, 2024 21:48
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
from
a82c5a7 to
f4a1cc7
Compare
rumenov
reviewed
Sep 5, 2024
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
from
f4a1cc7 to
35d7aea
Compare
anchpop
force-pushed
the
@anchpop/NNS1-3305
branch
from
35d7aea to
70bbb08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field is deprecated and no longer supported. This change is safe because neuron_parameters was already not supported by
Governance, this just removes the field entirely from the request it expects.← Previous PR