IC-530:Canister HTTP requests #7
Conversation
spec/index.adoc
Outdated
|
|
||
| The maximal size of a request URL is 2048 bytes. | ||
|
|
||
| The maximal size of a response is `TBD`. If a response is larger than this size, only the first `TBD` bytes will be returned. This size limit also applies to the value returned by the `transform` function. |
There was a problem hiding this comment.
“also”? Or “only”? I'd expect that larger responses can be processed and trimmed down by the transform function, as we really only have a problem with large messages when they enter consensus, and that’s post-transform.
There was a problem hiding this comment.
@yotamhc replaced TBD with 2MiB, we can modify this value later if needed, but for the first iteration, I think it's fine. Please see also Joachim's suggestion here. Is this something that we are planning to do now or maybe later, in the following iterations?
There was a problem hiding this comment.
@nomeata We also don't want to download too big responses (before the transform). We could have another limit for that, but opted to keep it simple for now. Do you think it's crucial to allow larger responses?
|
@JensGroth or @Dfinity-Bjoern, could you please let me know if there are any changes required before merging this PR? cc: @yotamhc |
|
@AlexandraZapuc should we merge this PR before the feature is available? |
|
Yes! At least originally the plan was:
I understand that for pragmatic reasons 4. happens first usually :-). Nevertheless, because this repo and the doc is versioned, it should be fine to merge and release stuff here that isn't live yet. |
EXC-929: Introduce HTTP_REQUEST method in IC00 This MR adds the new Ic00 method which handles the HTTP requests from canisters. Please see the [HTTP Requests Spec](dfinity/interface-spec#7) for more context. E2e tests will be handled in a separate MR. See merge request dfinity-lab/public/ic!3304
EXC-950: Add Canister HTTP response type This MR defines the canister HTTP response type from the [HTTP Requests Spec](dfinity/interface-spec#7). See merge request dfinity-lab/public/ic!3315
This PR provides the specifications for the feature IC-530: Canister HTTP requests.
The spec explains what are the constraints without explaining intricacies related to the underlying protocol.
For this first iteration:
2MiB(maximal size of a message in the consensus queue).