This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IC-530:Canister HTTP requests #7
IC-530:Canister HTTP requests #7
Changes from 6 commits
21c4d62
da47e4a
2c84d30
363f3f8
8fff092
eff6236
3cfd100
fb84ad7
f459742
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“also”? Or “only”? I'd expect that larger responses can be processed and trimmed down by the transform function, as we really only have a problem with large messages when they enter consensus, and that’s post-
transform
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yotamhc replaced
TBD
with2MiB
, we can modify this value later if needed, but for the first iteration, I think it's fine. Please see also Joachim's suggestion here. Is this something that we are planning to do now or maybe later, in the following iterations?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nomeata We also don't want to download too big responses (before the
transform
). We could have another limit for that, but opted to keep it simple for now. Do you think it's crucial to allow larger responses?